search

Devographics / Monorepo

Monorepo containing the State of JS apps
surveyform-sigma.vercel.app
Other
134 stars 52 forks source link

The Logo SVG for State of React 2023 has been set wrong `aria-label` value "State of JS 2021" #411

Closed taigakiyokawa closed 2 months ago

taigakiyokawa commented 3 months ago

Thank you for summarizing surveys and creating a great website!

I found a bit accessibility problem in that the State of React 2023 logo has wrong label by setting aria-label="State of JS 2021".

You can check the issue by accessing https://2023.stateofreact.com/en-US with DevTools and focusing on the <svg> element of the logo.

image (7)

Please check and fix it if you have free time 🙏 (Or, I can do it if you maintainers welcome my PR.)

Thank you.

taigakiyokawa commented 3 months ago

I saw there are the same problem in other survey logos:

https://github.com/search?q=repo%3ADevographics%2FMonorepo%20aria-label%3D%22State%20of%20JS%202021%22&type=code

SachaG commented 3 months ago

A PR would be great! Thanks for noticing this!

eric-burel commented 2 months ago

Thanks! I've tried to fix the issue but the thing is that it stems down from the result app having some copy-pasta around and use a kind of virtual system module, but I couldn't make the types right This is something that would be solved by some proper upgrade of the results app