Quick dependency causing conflict.

DiUS / pact-consumer-swift

A Swift / ObjeciveC DSL for creating pacts.

MIT License

98 stars 43 forks source link

Quick dependency causing conflict. #101

Closed isadamascena closed 3 years ago

isadamascena commented 3 years ago

Steps to reproduce:

Add the LaunchDarkly library with Swift Package Manager (version 5.2.0)
Add the pact-consumer-swift latest.

I get the error bellow:

Have you folks foreseen any action/work around for that version conflict on SPM? this can be a big issue since many libraries have Quick as dependency.

Thanks!

surpher commented 3 years ago

Thanks for reporting this @isadamascena!

Just to be clear, you're using SPM to handle dependencies, even pact-consumer-swift? It should be as simple as bumping up the Quick dependency version within pact-consumer-swift and any clean up required for Quick 3.x.x.

andrewspinks commented 3 years ago

I would suggest removing Quick as a dependency if it is causing an issue. It is only required to run the project tests (which we don't run by spm in the build anyway), it shouldn't be an enforced dependency on clients.

surpher commented 3 years ago

That would be ideal. Though it seems that SPM pulls in the dependencies per project, not per target or how Carthage does it with Cartfile.private. Looking into the structure, if it can be removed for distribution.

https://github.com/DiUS/pact-consumer-swift/blob/master/Package.swift