search

DiUS / pact-consumer-swift

A Swift / ObjeciveC DSL for creating pacts.
MIT License
98 stars 43 forks source link

Remove Nimble from framework build #103

Closed piellarda closed 3 years ago

piellarda commented 3 years ago

This PR moves Nimble to the private Cartfile and removes its use in the framework builds.

andrewspinks commented 3 years ago

@piellarda Thanks! I had just been testing a similar change https://github.com/DiUS/pact-consumer-swift/commit/e2ddcaf197eff04029fb348be3ebedddad73841a but this is more thorough. I think we should also remove the dependencies from the Package.swift as it seems to make the test dependencies requirements on any users of the library.

davdroman commented 3 years ago

Big +1. This would really help my company's migration to SPM :)