search

DiUS / pact-consumer-swift

A Swift / ObjeciveC DSL for creating pacts.
MIT License
98 stars 43 forks source link

fix: Use brew install when setting up tools for CI #113

Closed surpher closed 3 years ago

surpher commented 3 years ago

GitHub Actions runners started complaining when running the step to install required tools, specifically SwiftLint (https://github.com/DiUS/pact-consumer-swift/runs/1691359379?check_suite_focus=true#step:4:299).

With this change the script checks for CI environment variable and if it is set to true it installs only the missing tools using brew install. Otherwise, following CONTRIBUTING.md, it uses brew bundle and installs all the tools defined in Brewfile.

Builds for these changes have been running on my fork:

Note that the current build (and checks below) will still fail because it still uses the existing script in DiUS/pact-consumer-swift repo.

Fixes the GitHub Actions workflow settings and removes the workflow for macOS 11.x due to it being a "private preview". The reasoning to remove macos-11.0 as a valid workflow can be found here. Will keep the commit in the repo for when these runners become available.

surpher commented 3 years ago

Pushed directly. The setup of these forks and PRs is ridiculous and none of these checks display anything relevant.

bethesque commented 3 years ago

Told.