Closed surpher closed 3 years ago
Merging #115 (2ffa0d5) into master (250e8c8) will increase coverage by
0.05%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #115 +/- ##
==========================================
+ Coverage 91.80% 91.85% +0.05%
==========================================
Files 13 13
Lines 866 970 +104
==========================================
+ Hits 795 891 +96
- Misses 71 79 +8
Too many changes in different areas of the project in one PR. Closing and will "maybe" approach more methodically attacking each issue separately. Anyone else with time on their hands feel free to contact me with questions and for pointers on how to approach this.
Adds more variants of
localhost
toURLSessionDelegate
so thatPactVerificationService
can talk to an unsecure mock-server.It appears that
https://localhost
no longer triggers the delegate method where we could allow connections to hosts with self-signed certificates. InstantiatingPactVerificationService
onlocalhost
with allowing self signed certificates started failing when trying to connect topact-ruby-standalone
. Using127.0.0.1
works fine, provided the IP is in the delegate method and set to allow connections.Resolves the issue that uncovered this drawback: #114.
In order to get it building on CI, the following clean-up tasks have been done:
copy-frameworks
build phase in tvOS test target as this step is irrelevant in test targetsinstall_deps.sh
build.sh
script withtvOS
target