DiUS / pact-consumer-swift

A Swift / ObjeciveC DSL for creating pacts.
MIT License
98 stars 43 forks source link

fix: Repair tvOS scheme and improve exemptions in URLSessionDelegate #115

Closed surpher closed 3 years ago

surpher commented 3 years ago

Adds more variants of localhost to URLSessionDelegate so that PactVerificationService can talk to an unsecure mock-server.

It appears that https://localhost no longer triggers the delegate method where we could allow connections to hosts with self-signed certificates. Instantiating PactVerificationService on localhost with allowing self signed certificates started failing when trying to connect to pact-ruby-standalone. Using 127.0.0.1 works fine, provided the IP is in the delegate method and set to allow connections.

Resolves the issue that uncovered this drawback: #114.

In order to get it building on CI, the following clean-up tasks have been done:

codecov-io commented 3 years ago

Codecov Report

Merging #115 (2ffa0d5) into master (250e8c8) will increase coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   91.80%   91.85%   +0.05%     
==========================================
  Files          13       13              
  Lines         866      970     +104     
==========================================
+ Hits          795      891      +96     
- Misses         71       79       +8     
surpher commented 3 years ago

Too many changes in different areas of the project in one PR. Closing and will "maybe" approach more methodically attacking each issue separately. Anyone else with time on their hands feel free to contact me with questions and for pointers on how to approach this.