sebskuse commented 3 years ago

As discussed in https://github.com/DiUS/pact-consumer-swift/issues/120, paths in swiftlint's configuration file are now relative to the location of the file, so this moves the config file back to the root so those files point to the right place.

I made the smallest changeset I could here, potential controversial changes which I'm happy to change if you don't agree with:

Change filename to .swiftlint.yml to match swiftlint's default (i.e. a hidden file).
Updates swiftlint.sh to point at new config file. Technically shouldn't be required, as swiftlint should look for this file specifically, but I didn't want to change this file too much, not knowing your CI setup etc :)

codecov-io commented 3 years ago

Codecov Report

Merging #121 (c936425) into master (6ca8285) will increase coverage by 0.05%. The diff coverage is n/a.

:exclamation: Current head c936425 differs from pull request most recent head 2d4a104. Consider uploading reports for the commit 2d4a104 to get more accurate results

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   91.80%   91.85%   +0.05%     
==========================================
  Files          13       13              
  Lines         866      970     +104     
==========================================
+ Hits          795      891      +96     
- Misses         71       79       +8

surpher commented 3 years ago

Looks good and resolves #120. Thanks for this.

Controversial? Not really. It was set up in this way so it was portable to various CI systems and local dev enironments, where SwifLint was not necessarily installed via homebrew or used with its defaults.

mmysliwiec commented 2 years ago

Why this PR is not released? The last release is from February. This fix is kind of critical.

DiUS / pact-consumer-swift

Move swiftlint configuration to root #121

Codecov Report