Closed surpher closed 4 years ago
Merging #97 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 89.56% 89.56%
=======================================
Files 11 11
Lines 930 930
=======================================
Hits 833 833
Misses 97 97
xcpretty
tool does not seem to be working in our favour anymore on TravisCI when runningxcodebuild
commands.Suggestion is to replace it with
xcbeautify
.Changes:
xcpretty
withxcbeautify
forxcodebuild
command--no-skip-current
flag from the command that builds the dependencies forpact-consumer-swift
. Ifpact-consumer-swift
fails to build before even running tests etc, TravisCI.org hides the output in a hidden .log instead of printing it in the console for developer to see what has happened and quickly know how to fix it,scripts/build.sh
step that tests the framework builds as a Carthage dependency. This will try and build all the dependencies includingpact-consumer-swift
framework for Carthage.~ This has been introduced withc02537f6
--strict
from Swiftlint command to allow the bundle to build if only warnings (below threshold number) are found. This will allow more contributors to share their code while not be blocked by (sometimes) trivial cosmetic issues,c02537f6
xcodebuild
against (iPhone X -> iPhone ~11~ 8 (introduced withc02537f6
)). ~Using the latest stable Simulator available so we can fail sooner and fix it.~This PR will resolve #90