search

Dielee / volvo2mqtt

Home Assistant addon for connecting AAOS Volvos
MIT License
161 stars 37 forks source link

Supervisor log reports missing options #239

Closed ezande closed 1 month ago

ezande commented 2 months ago

Describe the bug Since this add-on was updated to 1.10.x the Home Assistant Supervisor log shows WARNING (MainThread) [supervisor.addons.options] Unknown option 'odometerMultiplier' for Volvo2Mqtt (982ee2c4_volvo2mqtt) WARNING (MainThread) [supervisor.addons.options] Unknown option 'averageSpeedDivider' for Volvo2Mqtt (982ee2c4_volvo2mqtt) WARNING (MainThread) [supervisor.addons.options] Unknown option 'averageFuelConsumptionMultiplier' for Volvo2Mqtt (982ee2c4_volvo2mqtt)

These option are removed in v1.10.0 but not completely I guess.

I have tried to remove the startup options from the "Volvo configuration options" but once the add-on is restarted the option reappear with their default value: odometerMultiplier: 1 averageSpeedDivider: 1 averageFuelConsumptionMultiplier: 1

Looks like there is still code to set these options to their default.

To Reproduce:
Steps to reproduce the behavior:

  1. Go to Settings -> Add-ons -> Volvo2Mqtt -> Configuration
  2. Remove above options from Volvo configuration settings
  3. Restart Add-on
  4. Check Supervisor logging under Settings -> System -> Logbook -> Supervisor

Expected behavior:
Options should no longer be in the config

Screenshots:
None

Version info:
Started after update to V1.10.0

Logs:
None

Dielee commented 2 months ago

Ah, my bad..I will fix this tomorrow!

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

maxxnet2 commented 1 month ago

Is it fixed?

ezande commented 1 month ago

No, don't think so. Still on V1.10.1 which has this issue also. Not very important though, everything works fine except for some logging, so no hurry...

Dielee commented 1 month ago

Fixed by v1.10.2

ezande commented 1 month ago

Installed 1.10.2 but output of supervisor log remains the same. (Tried restart of HomeAssistant also)

2024-10-16 09:10:02.877 INFO (MainThread) [supervisor.docker.addon] Starting Docker add-on 982ee2c4/amd64-addon-volvo2mqtt with version 1.10.2 2024-10-16 09:10:02.937 WARNING (MainThread) [supervisor.addons.options] Unknown option 'odometerMultiplier' for Volvo2Mqtt (982ee2c4_volvo2mqtt) 2024-10-16 09:10:02.937 WARNING (MainThread) [supervisor.addons.options] Unknown option 'averageSpeedDivider' for Volvo2Mqtt (982ee2c4_volvo2mqtt) 2024-10-16 09:10:02.937 WARNING (MainThread) [supervisor.addons.options] Unknown option 'averageFuelConsumptionMultiplier' for Volvo2Mqtt (982ee2c4_volvo2mqtt)

2024-10-16 09:11:48.393 INFO (SyncWorker_4) [supervisor.docker.manager] Restarting homeassistant 2024-10-16 09:11:48.453 INFO (MainThread) [supervisor.api.proxy] Home Assistant WebSocket API for d5369777_music_assistant closed 2024-10-16 09:11:57.134 INFO (MainThread) [supervisor.homeassistant.core] Wait until Home Assistant is ready 2024-10-16 09:11:59.157 INFO (MainThread) [supervisor.resolution.evaluate] Starting system evaluation with state running 2024-10-16 09:11:59.233 INFO (MainThread) [supervisor.resolution.evaluate] System evaluation complete 2024-10-16 09:11:59.256 WARNING (MainThread) [supervisor.addons.options] Unknown option 'odometerMultiplier' for Volvo2Mqtt (982ee2c4_volvo2mqtt) 2024-10-16 09:11:59.256 WARNING (MainThread) [supervisor.addons.options] Unknown option 'averageSpeedDivider' for Volvo2Mqtt (982ee2c4_volvo2mqtt) 2024-10-16 09:11:59.256 WARNING (MainThread) [supervisor.addons.options] Unknown option 'averageFuelConsumptionMultiplier' for Volvo2Mqtt (982ee2c4_volvo2mqtt) 2024-10-16 09:12:02.207 INFO (MainThread) [supervisor.homeassistant.core] Home Assistant Core state changed to APIState(core_state='NOT_RUNNING', offline_db_migration=False)

ezande commented 1 month ago

Ah, my bad, forgot to remove parameters from config file. Sorry! Works as designed now.