DigiKrafting / blender_addon_pbr

Provides a material panel that creates Metallic/Roughness or Specular/Gloss Nodes using the Principled BSDF shader.
GNU General Public License v3.0
35 stars 5 forks source link

Auto Texture not working properly #3

Closed Harvester62 closed 7 years ago

Harvester62 commented 7 years ago

I have a folder with three textures which include in their names the hardcoded terms "Base_Color", "Normal" and "Roughness" but the add-on doesn't seem to recognize them and automatically assign to the fields of Textures | Base Color, Normal and Roughness.

May I suggest you to look at the Node Wrangler add-on since it uses a smart and flexible way to recognize each single type of texture map. It could greatly improve the efficiency of your add-on. My two cents.

Furthermore, if I click on the Open buttons to manually choose the textures the Auto Texture path previously set doesn't open up in the File Browser and the root drive (C:\ in may case on Windows 10 Pro 6bit) is being displayed instead. I would expect that the selected path would be used so to manually pick up the individual files.

Thanks.

DigiKrafting commented 7 years ago

Hi Harvester62,

I've tried various textures sets with the auto texture and was unable to reproduce the issue you had, would it possible for to see if any errors are reported in Blenders System Console? (I've extended the matching to include more naming variations with more to come soon as I have lots of models from various sources to import and apply PBR textures to).

I agree that the default path should be picked up from the Auto Texture Path for unmatched textures but as far as I'm aware this is not currently possible in Blenders API. Blender will default to C: for unsaved files or the current .blend path if saved.

I've had a quick look at the Node Wrangler addon and will spend some more time on it this weekend.

Any further info you can give in regards to your textures not being applied will be appreciated.

Thanks

DigiKrafting commented 7 years ago

Hi Harvester62,

I believe the issue you had with the textures not being set may of been due to the Relative Path being selected. This is now catered for, could you please confirm, thank you.

Harvester62 commented 7 years ago

I confirm that the issue is caused by the Relative Path option selected when you set the search directory for the textures. Deselecting it before completing the operation works perfectly and all the textures are loaded correctly.

Glad to know that you're working on improving the texture's naming recognition. Keep the good job. Thank you.

Harvester62 commented 7 years ago

Hi,

I did reply in the GitHub tracker. Thank you for the advice.

I think it would be good to be able to use relative paths, especially when a .blend file is inside a production tree directory, where everything is relative to the root directory of the project, This allow you to move, transfer the entire project's directory structure elsewhere preserving all the relationships and dependencies.

Thank you

2017-10-06 13:12 GMT+02:00 Digiography.Studio notifications@github.com:

Hi Harvester62,

I believe the issue you had with the textures not being set may of been due to the Relative Path being selected. This is now catered for, could you please confirm, thank you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Digiography/blender_addon_pbr/issues/3#issuecomment-334726491, or mute the thread https://github.com/notifications/unsubscribe-auth/Aca6R3uo7AIGzpPap8wQkvIDyyih7jlyks5spgsjgaJpZM4PtU5f .

-- Riccardo Giovanetti

DigiKrafting commented 7 years ago

Hi Harvester62 ,

Apologies, I may of deleted the release/tags it was connected to, I don't like having buggy code and I'm all for less clicking and tighter pipeline intergration. (I'm new to github, will investigate tracker later, more docs to read :))

I've just committed an update to 1_5_0 and have gotten the relative paths to work with additional classes.

Thanks again for checking out the addon out and for help your feedback, advice and suggestions.