DigitalCommons / open-data-and-maps

Deprecated: Implementation of Linked Open Data by the Solidarity Economy Association
6 stars 1 forks source link

Markers disappearing #198

Closed ColmMassey closed 4 years ago

ColmMassey commented 4 years ago

It is not uncommon for markers to disappear when using sea-app.

Try dotcoop.solidarityeconomy.coop It is not reliably repeatable, but occurs often enough that it shouldn't take too long to replicate.

It has been observed on both Chrome and Firefox on Windows 10. The way to replicate is to use the Directory select countries and then to zoom to include all co-ops in that country by clicking the country name bar above the list of co-ops in the country. Moving between countries with several co-ops and then with only one or two like Belarus or Haiti frequently induces the error. Reselecting the co-op in the directory, or hiding the panel usually causes the marker to reappear.

ColmMassey commented 4 years ago

This has not been obsrved since the changes make to support hiding markers of initiatives that were not identified in a search, so happy to close.

ColmMassey commented 4 years ago

Actually I am still seeing this a lot. Zooming in and out induces it to return.

ColmMassey commented 4 years ago

This happening a lot on new ICA map.

sunnydean commented 4 years ago

This should be fixed alongside with the disappearing tiles fix (presumably) Since I am failing to replicate it, could someone please test it out? @ColmMassey @wu-lee Thanks! check out the new ica map: http://dev.ica.solidarityeconomy.coop/

ColmMassey commented 4 years ago

It would be useful to be able to test this on a bigger data set. Can you push the changes to dev.dotcoop.etc... ?

sunnydean commented 4 years ago

https://dev.dotcoop.solidarityeconomy.coop/ Sure @ColmMassey

I don't see it happening but please double check

ColmMassey commented 4 years ago

I have observed it once, on Chrome. Seems less frequent, but not fully solved. I wonder is there any logging I can capture to share when I observe it.

ColmMassey commented 4 years ago

Also I think you may have made clustering at co-located addresses worse. Check out either Iran clusters on either Chrome or FIrefox.

sunnydean commented 4 years ago

I can further look into disappearing markers it if needed. could we have a really quick call to demo the bug on your screen because I cannot seem to replicate it at all? (Make sure to use incognito to get the new code)

I saw the issue with clustering though, will start fixing that next!

ColmMassey commented 4 years ago

I think you have solved the main cause of markers disappearing, (that is independent of the clustering issue). I have only observed it once in the last 1/2 hour of hammering it, so let's close this for now.

sunnydean commented 4 years ago

Note: We can reopen if it comes about again I have a couple of other solutions if needed :)