Closed dakomura closed 9 months ago
Awesome, thank you very much. @dakomura I really appreciated it.
Hi @dakomura ,
I made some big changes to the anno_img: (1). It supports remote URL as input. (2). It supports missing values now. (3). Fix bugs about the order and rotation of rows and columns image annotations. Please see here for some example
Could you please install the latest version from github and help me test those new features?
Hi @DingWB ,
I apologize for not making any progress on the examples. I've been extremely busy lately and haven't had the opportunity to work on them.
Thank you so much for implementing those new features in anno_img! I sincerely appreciate your effort. I'll make sure to install the latest version from GitHub and thoroughly test it next week. If I have any feedback or suggestions, I'll be sure to let you know.
Hi Wubin,
Thanks for merging the pull request and adding the use of
anno_img
to the documentation. I appreciate your feedback and suggestions.Regarding the image size issue, my approach assumes that all images are exactly the same size. If this is not the case, the current code will indeed encounter errors during the
np.hstack
ornp.vstack
operations. To address situations where images may vary in size and aspect ratio, implementing a comprehensive solution becomes complex. Therefore, I decided to use assertions to enforce that images within the same cluster must have identical sizes.https://github.com/dakomura/PyComplexHeatmap/blob/951ecb9f15d765bdd3f811dd228d8c1e7cb744ac/PyComplexHeatmap/annotations.py#L1149-L1155
As for the
merge
parameter, while the need to merge images is rare, there are scenarios where it could be beneficial to display a single image for a particular category or cluster. Since the implementation was straightforward, I included this feature.https://github.com/dakomura/PyComplexHeatmap/blob/951ecb9f15d765bdd3f811dd228d8c1e7cb744ac/PyComplexHeatmap/annotations.py#L1163-L1169
I will be sure to send you the Jupyter notebook when it is finished and contains a better example of
anno_img
used with real biological data. This example will be suitable for inclusion in the documentation website.Best regards,
Daisuke