Gladiatus Update 4.3.1 Bugs

[FrutyX]

Gameforge moved their images to a new URL location, so images GCA is using are not being loaded and that is causing a mess.

Reports are failing to detect enemies URL:

🟢 Status: FIXED

`Failed to detect enemy url("//gf3.geo.gfsrv.net/cdn29/bac7e539d61a9de6caec21363c2694.jpg")`

Mystery box rubies prices unknown:

🟢 Status: FIXED


Pantheon quests bugged:

🟢 Status: FIXED

``` pantheon.quests.js?4.3.6&built=1658150383374:82 Uncaught TypeError: Cannot read properties of null (reading '1') at Object.quests_reorder (pantheon.quests.js?4.3.6&built=1658150383374:82:122) at Object.inject (pantheon.quests.js?4.3.6&built=1658150383374:15:9) at fireLoad (pantheon.quests.js?4.3.6&built=1658150383374:180:23) ```

Guild battle report bugged:

🟢 Status: FIXED


Add to Target List bugged:

🟢 Status: FIXED


Gold&XP Statistics Icon bugged:

🟢 Status: FIXED


Negotium X enemies bugged:

🟢 Status: FIXED


Buffs bugged when viewing other player profiles:

🟢 Status: FIXED


CT and Dungeons table overview bugged:

🟢 Status: FIXED

 ``` Failed to load resource: the server responded with a status of 404 (Not Found) char_status_kopf_b.jpg:1 Failed to load resource: the server responded with a status of 404 (Not Found) char_status_abschluss_b.jpg:1 ```

Durability loss numbers are bugged with GCA enabled:

🟢 Status: FIXED


Attack guild button missing in War Master Hall:

🟢 Status: FIXED


Library level indicator bugged:

🟢 Status: FIXED


... more will be added when found.

[GramThanos]

Sum up:

Show enemy drops was disabled - (a walk-a-round to identify NPCs is needed) Reorder quests was disabled - (a walk-a-round to identify quest categories is needed) Image caching was disabled - (this was a Gladiatus bug fix feature, we have to re script it, the bug is still here)

[FrutyX]

⚠️ A very quick list update has been made.

[GreatApo]

Sum up:

Show enemy drops was disabled - (a walk-a-round to identify NPCs is needed) Reorder quests was disabled - (a walk-a-round to identify quest categories is needed) Image caching was disabled - (this was a Gladiatus bug fix feature, we have to re script it, the bug is still here)

For NPCs the fastest way is probably caching the names when you visit each location. For quests, more extreme measures like identifying images by comparing pixels at specific locations of converting the images to base64 may be required (that may be heavy for old PCs).

[GramThanos]

Sum up: Show enemy drops was disabled - (a walk-a-round to identify NPCs is needed) Reorder quests was disabled - (a walk-a-round to identify quest categories is needed) Image caching was disabled - (this was a Gladiatus bug fix feature, we have to re script it, the bug is still here)

For NPCs the fastest way is probably caching the names when you visit each location. For quests, more extreme measures like identifying images by comparing pixels at specific locations of converting the images to base64 may be required (that may be heavy for old PCs).

NPCs > You have to identify the location too Quests > The images are loaded from an other domain, thus javascript does not have access to their pixels.

[FrutyX]

After a while, found a new bug, added on the list.

[FrutyX]

According from what I've seen on Glad discord, it appears the "attack other guilds" button is bugged with GCA enabled, can someone confirm this? I can't, no guilds to attack.

[GramThanos]

FYI, since message icons changed, the addon can't detect the message type, thus features like loading the guild battle report do not work.

[FrutyX]

Uhhh, what feature was that again, I haven't seen that in a while.

This is supposed to look different right? There was an overview of the battle I believe?

[GramThanos]

The addon was loading the report and was showing the battle results in a report like way (attacker vs defender with points).

[FrutyX]

I see, added on the list.

[FrutyX]

Very awesome, Thanos is today's MVP.

[SleepingShadow-bit]

Unfortunately I don't see any change in the quest. Correctly?

[FrutyX]

Something wrong on your side, it is fixed, remove the addon completely.

[SleepingShadow-bit]

New downloaded Data and cache cleared... Grml. I will check again dude

[GreatApo]

New downloaded Data and cache cleared... Grml. I will check again dude

It's just reordering the quests, not too much of a change

[SleepingShadow-bit]

Reinstalled twice - no success. Third time installed - fine.
Thanks for the fix

[FrutyX]

Btw, you did reinstalled, but have you restarted your browser? I want the truth :D

[SleepingShadow-bit]

Btw, you did reinstalled, but have you restarted your browser? I want the truth :D

Hmm good question. I don't think so haha Its my bad xD

[GramThanos]

Probably we will have to move CDN related code to a new script... The resources drop will work now, but not all enemies can be identified.

[FrutyX]

Oh god

[GreatApo]

Oh god

Can you paste the links?

[FrutyX]

Yes of course, sorry.

//gf1.geo.gfsrv.net/cdn96/28735e13275819747922c16a516a5b.jpg
//gf3.geo.gfsrv.net/cdn24/d84f6adad4686ae45ff5b98fcbc692.jpg
//gf2.geo.gfsrv.net/cdn13/b173612baddf3d7dadbcdb823d3a19.jpg
//gf3.geo.gfsrv.net/cdn29/bac7e539d61a9de6caec21363c2694.jpg

[FrutyX]

Here is some more, two last Britannia locations are locked for me unfortunately.

//gf1.geo.gfsrv.net/cdn9d/d8e4b82f457b0803419ce2c50f5255.jpg
//gf3.geo.gfsrv.net/cdne8/5d44a11052e740a8ec483e76f181a7.jpg
//gf1.geo.gfsrv.net/cdn67/a2611142886c9c6634cbb31e0cdb5e.jpg
//gf1.geo.gfsrv.net/cdn94/30c496661bc490a06b5c212124f4fe.jpg

//gf1.geo.gfsrv.net/cdnc5/8fc1dc28a272c41b475828a8107afe.jpg
//gf3.geo.gfsrv.net/cdn8d/0ead089e64b248786fb3e126ffcf7f.jpg
//gf3.geo.gfsrv.net/cdn58/99db5b8f77050f201cf67dc8e5bf9d.jpg
//gf1.geo.gfsrv.net/cdn63/cdbea7d87f34475e22555256f0f942.jpg

//gf1.geo.gfsrv.net/cdn64/b98041c012f259885ba823c53eeaca.jpg
//gf2.geo.gfsrv.net/cdnab/195c75c0ba9e8fadda41b58b107b84.jpg
//gf1.geo.gfsrv.net/cdn32/3ae0563db2cd7241d349f766002b3b.jpg
//gf1.geo.gfsrv.net/cdncd/9dd0228c3a6c8dfe9e5b9bd20f50a5.jpg

//gf1.geo.gfsrv.net/cdnf3/841d17a434e2018c8c84c1fa2271a5.jpg
//gf1.geo.gfsrv.net/cdn63/e3e4aa1f515a7c28ce7812c3ac63b7.jpg
//gf1.geo.gfsrv.net/cdn04/f4e1cd5cd2438f5a41c47814d0a710.jpg
//gf2.geo.gfsrv.net/cdn1b/18b0984d6a55da3e034e4760628b7f.jpg

[GreatApo]

That should be enough data for that Thanos to crack the rest :P Alternatively, we will have to gather them by hand.

[FrutyX]

By the way, I know this is still work in progress, but with those URLs added, I am still getting those reverse lookup url errors, just letting you know.

[FrutyX]

Alright, so now tell me, what is the status of detect enemies bug? Are you gonna improve it or we can call it fixed? We don't have the two last Britannia locations, I don't know if Thanos can get them without accessing them, if not, just tell me and I will put some personal effort, to get those URLs from someone.

[GreatApo]

Alright, so now tell me, what is the status of detect enemies bug? Are you gonna improve it or we can call it fixed? We don't have the two last Britannia locations, I don't know if Thanos can get them without accessing them, if not, just tell me and I will put some personal effort, to get those URLs from someone.

Thanos managed to optimize and get the hash keys for most images, but some of them (the ones commented) are wrong (they probably have a different optimisation and different hashes are generated. We will gradually collect them all, you don't have to gather the links because I still need to sort them and link them to the previous image links.

[FrutyX]

Alright then, if you need some help in a way I am able to, you know where to find me.

I'll keep it as WIP status for now.

[FrutyX]

Failed to detect enemies in underworld when a secondary drop drops (no costume), but I can also see that UW enemies weren't added yet, so if this is helpful:

Our avatar (no costume): https://gf2.geo.gfsrv.net/cdn12/124a63795958541c73a4e72afa1eb1.jpg Mercury: https://gf1.geo.gfsrv.net/cdn67/3754533f396ef58b2a2e6e10ae2ce1.jpg Dead Souls: https://gf1.geo.gfsrv.net/cdn0e/150f321a110eb56d29722525352ab8.jpg Ferryman Charon: https://gf1.geo.gfsrv.net/cdnc2/45b98b77994de23b38c7d7a4c66cc6.jpg

Cerberus: https://gf3.geo.gfsrv.net/cdn55/23d1b46fc425b94d47901cfa26b617.jpg Aeacus: https://gf1.geo.gfsrv.net/cdn3a/91992511c6e3d3a12395c809a2af6b.jpg Rhadamanthus: https://gf3.geo.gfsrv.net/cdneb/a0bee3578089807e4903068fb7bf78.jpg Minos: https://gf3.geo.gfsrv.net/cdn2d/bf68cbfb4a12f9876f83cd855ba703.jpg

Hydra: https://gf2.geo.gfsrv.net/cdn1a/abc607343a9b46c6b69173b19f434f.jpg Centimanes: https://gf2.geo.gfsrv.net/cdn40/229a35f7226acf2deb140a59394853.jpg Tisiphone: https://gf1.geo.gfsrv.net/cdn36/46eebfc698733002bdb9d50168fa34.jpg Typhon: https://gf2.geo.gfsrv.net/cdn40/ad32b6084a5cf5178b83d6a0ee3230.jpg

Proserpina: https://gf2.geo.gfsrv.net/cdnd2/6703d930e67e77674d505a6c2c9d3a.jpg Alecto & Megaera: https://gf3.geo.gfsrv.net/cdn20/45bc06f6e42d5840b4cb077809bced.jpg Sphinx: https://gf2.geo.gfsrv.net/cdn70/739ca8bf810cde7cac6ab78c2da517.jpg Dis Pater: https://gf1.geo.gfsrv.net/cdnf8/78e9dd30a5e0f07d5be66c9bae9dd4.jpg

(Bonus) Unknown: https://gf2.geo.gfsrv.net/cdnae/904194973d21066c96cb414d04d676.jpg

[FrutyX]

The feature, that is supposed to show rubies price in the mystery box prize pool is bugged, it appears it's also because of image links:

 

[FrutyX]

Nevermind, ignore the last message (deleted it), it was something I caused :).

[GramThanos]

The only problem that still exists is the fact that some images are the same for multiple NPC enemies, thus from the url of the CDN image, we can not understand which NPM it is. In these cases, the addon assumes that the it is the first of the NPCs. This may cause problems on the drop statistics but for now, I think these NPCs are not in expedition locations.

I craweld the images from the gamefoge servers, and added all the enemies from the expeditions on the data. Furthermore, following gf approach, I implemented a code to try and map images that the addon is using on the CDN servers to reduce the load on the main game servers. This uses as a fall back the /cdn/ directory.

So right now you may encounter an error Image link "{CDN-LINK-HERE}" was not found on CDN lookup list. which does not break the addon but informs us that this image is missing from our data. And also you may encounter a warning Image path "{OLD-IMG-PATH}" was not found on CDN lookup list. Using "{CDN-FOLDER-FALLBACK}". which just informs us that data to map this image to the CDN server are missing.

[GramThanos]

To sum up. Expedition drops should work. On mystery box not all custome drops are detectable (does not affect outcoume). Not all images used from the addon points to the CDN (does not affect the addon's operation).

Thus, if we don't have any other problem, we may start releasing a version.

[FrutyX]

So for now, this is expected?

[GramThanos]

it depends on where you found it.

[FrutyX]

I've reinstalled GCA and restarted my browser to be sure, it seems this one is gone now, but I'll keep my eye on it.

[FrutyX]

Hmmm, the stuff that is not buyable for rubies, or does not have a ruby value, should probably not have a value shown? Potions are an example.

[FrutyX]

@GramThanos I need something from you, a confirmation, all I need you to do is, to make me a screen of an enemy, but the enemy needs his materials shown, that's all.

[FrutyX]

And as he magically appeared, he also disappeared 🤣 .

[GramThanos]

It's beer o'clock mate.

[GreatApo]

[FrutyX]

Nice, now that is understandable!

[GramThanos]

@FrutyX

[FrutyX]

Good, thanks.

With those updates and merges, Gameforge also did some changes to their CSS (or just the page layout), and some GCA things are moved, however I wanted an confirmation, because I am using a custom scaling in my Windows, and sometimes it's changing things the way they should not look like (bad page rendering, but they did improved it a lot in Chrome), I do have my ways to test it, but I wanted to be 100% sure.

[FrutyX]

Hmm, I think the training page doesn't work, can you do a quick check?

Uncaught SyntaxError: Unexpected identifier (at training.js?4.3.6&built=1659739158298:220:61)

[FrutyX]

Think I've fixed it, I guess.

[GramThanos]

Kind of :P

It was a syntax error, meaning the interpreter (the program that reads and executes the code) was not able to read the file as the JavaScript syntax was not correct.

In particular we had a string, then space, then a function call. You added the semicolon, which fixed the syntax but this was not the intended thing to do. The part that I broke was that I forgot to add a + sign, which means concatenate the string with the function call's return value, creating a new string.

Got it?

[FrutyX]

Yeah, probably, yes, I do.

:D

[FrutyX]

Well, if you don't plan any changes or improvements for the reports and mystery box values, I would say we are pretty much ready to release 4.3.6, however, there is always room for improvements, testing and bug catching, always something to do, and since you don't release a new version very often, then we need to make sure, that this is it.

[FrutyX]

I am aware, that you are aware, but if any helpful:

Not found on CDN lookup list:

https://gf1.geo.gfsrv.net/cdn37/c4364b8ac67369247214b8f71fd0b5.jpg

Failed to detect enemy:

https://gf1.geo.gfsrv.net/cdnf8/78e9dd30a5e0f07d5be66c9bae9dd4.jpg https://gf3.geo.gfsrv.net/cdn29/bac7e539d61a9de6caec21363c2694.jpg

Looking for errors is pain now, because logged errors are spammed with all these cdn warnings.