search

Distributive-Network / PythonMonkey

A Mozilla SpiderMonkey JavaScript engine embedded into the Python VM, using the Python engine to provide the JS host environment.
https://pythonmonkey.io
Other
854 stars 40 forks source link

Add more type hints & documentations for the public API in the `.pyi` stub file #364

Closed Xmader closed 5 months ago

Xmader commented 5 months ago

For https://github.com/Distributive-Network/PythonMonkey/pull/364/commits/f1f324162cf1ae3e7cf79d29964e2e9892524733, the type definitions were deleted in commit https://github.com/Distributive-Network/PythonMonkey/commit/d946421c2ef75e10f7c7f527f0d473bb087b3cde and https://github.com/Distributive-Network/PythonMonkey/commit/1f42778740b89e8f6947b13b2c6b4c80267f298c.

pm.bigint is very useful when losslessly converting a Python int into JS and back (see https://github.com/Distributive-Network/PythonMonkey?tab=readme-ov-file#integer-type-coercion), thus must be included in the typings for the public API.