Build SpiderMonkey from `mozilla-central`

Distributive-Network / PythonMonkey

A Mozilla SpiderMonkey JavaScript engine embedded into the Python VM, using the Python engine to provide the JS host environment.

https://pythonmonkey.io

Other

854 stars 40 forks source link

Build SpiderMonkey from `mozilla-central` #367

Closed Xmader closed 4 months ago

Xmader commented 5 months ago

Switching to mozilla-central from the ESR versions could save us from bugs that were solved several months ago in upstream SpiderMonkey tip but haven't been backported to ESR.

In order to make the target version consistent, the mozilla-central commit hash to be used is stored in the mozcentral.version file.

Xmader commented 5 months ago

~~Windows build is disabled for now~~

Fixed in https://github.com/Distributive-Network/PythonMonkey/pull/367/commits/3883b623bbc54a5fbd9888cc030c9360e2bf67f2

Xmader commented 5 months ago

~~pmdb is disabled for now~~

Fixed in https://github.com/Distributive-Network/PythonMonkey/pull/367/commits/180303f94a761772b43aa987e4f9d43dc48ba2ae

Xmader commented 4 months ago

TODO

[x] Add CI to automatically update the commit to the tip and make pull requests (done in https://github.com/Distributive-Network/PythonMonkey/pull/367/commits/a7b92e896ff6b077f161b9ae79a9f5e55f4434b5)
[ ] Figure out JobQueue for JS::AutoDebuggerJobQueueInterruption (see https://hg.mozilla.org/releases/mozilla-esr128/file/tip/js/src/builtin/Promise.cpp#l6946) (would be separate PRs)
[ ] Takeaways

Xmader commented 4 months ago

@philippedistributive https://github.com/Distributive-Network/PythonMonkey/pull/367/commits/53af133ac3cecc4ff0d20fc871fcd4d121a10916

setWeakRefsEnabled and setIteratorHelpersEnabled both no longer exist on JS::RealmCreationOptions - they moved to SpiderMonkey/Firefox prefs (See https://hg.mozilla.org/mozilla-central/file/d25c9bd/modules/libpref/init/StaticPrefList.yaml#l7803).