DoSomething / voting-app

☑ Voting app for DoSomething.org campaigns.
MIT License
6 stars 4 forks source link

Update Gateway & increase access token column length. #551

Closed DFurnes closed 7 years ago

DFurnes commented 7 years ago

What's this PR do?

This pull request updates the Voting App to use Gateway 1.3, applies the included migration to increase the column length for access tokens to accommodate longer tokens, and switches to the AES-256-CBC cipher for compatibility with the latest Homestead.

How should this be reviewed?

Logging in via Northstar should continue to work.

Any background context you want to provide?

We're increasing the length of the private key used to sign tokens in Northstar to keep things nice and locked down, and that also increases the length of the generated tokens to over 1024 characters. The AES-256-CBC cipher (used for encrypting cookies & sessions) is removed in Laravel 5.3 and deprecated in PHP 7.1, so we're updating that to the new default.

What are the relevant tickets?

Trello Card

Checklist

DFurnes commented 7 years ago

This is blocked on DoSomething/devops#241.

DFurnes commented 7 years ago

Rebased after merging #553 and this is now looking good! 🏁