Closed nlbuescher closed 4 years ago
I don't remember clicking Close
. I think GitHub thought it was doing something smart when I merged the other PR.
I've created a docking
branch for you to merge into.
Apart from the generated files you shouldn't have too many conflicts.
Side note:
I am considering removing the generated files from Git but I don't want contributors to worry about installing swig
. How was your experience with swig? Was it painless to install?
I run linux, so all I had to do was a pacman -S swig
, and on macOS the trusty brew install swig
, but I did have to install it. It did take me a hot minute to realize I had to run the swig and codegen tasks separately from the build task, but other than that, and the withJava
bug, there wasn't much issue.
I think keeping the generated files is probably worth doing for the sake of some form of documentation.
I also can't reopen the PR, might have to create a new one
It's because I deleted the base branch. :sweat_smile:
Ah yes. New PR it is then. I can't change the branch, I'm finding.
I chose
imgui-1.76
as the branch for now because that's what it's based on. If you could create adocking
branch based onimgui-1.76
, then I can change the branch.Updates as discussed in #7.