DopplerHQ / cli

The official CLI for interacting with your Doppler secrets and configuration.
https://docs.doppler.com
Apache License 2.0
226 stars 44 forks source link

Add support for generating and installing shell completions #172

Closed Piccirello closed 3 years ago

Piccirello commented 3 years ago

This supports generating completions for bash and zsh, and installing completions for bash.

Closes DPLR-585

Piccirello commented 3 years ago

Is it correct that you have to run a command to enable the completion? Can we have this on by default, or are there some downsides to that?

That is correct. I'm tracking automated installation in DPLR-1376.

Piccirello commented 3 years ago

Both great suggestions, will update.

Piccirello commented 3 years ago

@ryan-blunden I addressed your comments with some minor modifications. Can you take another look and lmk your thoughts (diff)?

ryan-blunden commented 3 years ago

Brilliant! Helpful and to the point.