DopplerHQ / cli

The official CLI for interacting with your Doppler secrets and configuration.
https://docs.doppler.com
Apache License 2.0
219 stars 44 forks source link

Fix install.sh failing on retried curl requests #211

Closed Piccirello closed 3 years ago

Piccirello commented 3 years ago

When curl encounters a 5xx error, it retries the request. The request is retried until all attempts are exhausted, or until one of the attempts succeeds. In the event a curl retry succeeded with a 200, install.sh would incorrectly parse the response as a failure. This meant that any curl request that failed on the first attempt but succeeded on a subsequent attempt would still be considered a failure. Note that this bug did not affect wget because wget does not retry on 5xx.

Closes ENG-2011.