search

DopplerHQ / cli

The official CLI for interacting with your Doppler secrets and configuration.
https://docs.doppler.com
Apache License 2.0
219 stars 44 forks source link

[ENG-2162] Handle '=' in secret values #216

Closed zbuc closed 3 years ago

zbuc commented 3 years ago

Should handle '=' appearing inside secret values.

Noticed another issue that prevents setting two secrets at once: https://linear.app/doppler/issue/ENG-2257/doppler-cli-doesnt-support-setting-two-secrets-at-once

zbuc commented 3 years ago

Not sure why this is failing, I'm unable to run the test-e2e make target locally to test:


$ make test-e2e
./tests/e2e.sh
INFO: Executing 'secrets-download-fallback' tests
Doppler Error: The fallback file does not exist
ERROR: 'secrets-download-fallback' tests failed during execution
INFO: Completed 'secrets-download-fallback' tests
make: *** [test-e2e] Error 1```
rgmvisser commented 3 years ago

Not sure why this is failing, I'm unable to run the test-e2e make target locally to test:

$ make test-e2e
./tests/e2e.sh
INFO: Executing 'secrets-download-fallback' tests
Doppler Error: The fallback file does not exist
ERROR: 'secrets-download-fallback' tests failed during execution
INFO: Completed 'secrets-download-fallback' tests
make: *** [test-e2e] Error 1```

Do the tests pass when you run this without your changes?

zbuc commented 3 years ago

Not sure why this is failing, I'm unable to run the test-e2e make target locally to test:

$ make test-e2e
./tests/e2e.sh
INFO: Executing 'secrets-download-fallback' tests
Doppler Error: The fallback file does not exist
ERROR: 'secrets-download-fallback' tests failed during execution
INFO: Completed 'secrets-download-fallback' tests
make: *** [test-e2e] Error 1```

Do the tests pass when you run this without your changes?

locally, no

Piccirello commented 3 years ago

Can you squash these commits into one?

zbuc commented 3 years ago

@Piccirello done

Piccirello commented 3 years ago

Can you also cleanup the commit message a bit, just so that users have a bit more context when the see the line-item in their terminal. Something like "Fix handling of values containing '=' when setting secrets".

zbuc commented 3 years ago

Done

On Wed, May 19, 2021 at 4:16 PM Tom Piccirello @.***> wrote:

Can you also cleanup the commit message a bit, just so that users have a bit more context when the see the line-item in their terminal. Something like "Fix handling of values containing '=' when setting secrets".

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DopplerHQ/cli/pull/216#issuecomment-844438584, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAELFOCRV7AJ2WAHR5UK4FTTOQMCBANCNFSM44WK6PAA .

Piccirello commented 3 years ago

I think you picked up a couple additional commits in the process. You can likely fix this with a rebase: git pull --rebase origin master