search

DopplerHQ / cli

The official CLI for interacting with your Doppler secrets and configuration.
https://docs.doppler.com
Apache License 2.0
218 stars 44 forks source link

Use existing installation location if one exists #304

Closed watsonian closed 2 years ago

watsonian commented 2 years ago

This adds an additional check to see if the Doppler CLI already exists on the PATH somewhere. If it does, it uses that as the installation location. It addresses problems introduced by Homebrew switching to installing under /opt/homebrew and will also make it so users who installed to a custom location using --install-path get updated properly when doppler update is run.

Closes ENG-2166

watsonian commented 2 years ago

I think this is good to go now. I squished the commits down and have tests. Let me know if you see anything that could use some refinement.

rgmvisser commented 2 years ago

Good stuff @watsonian ! :)

Piccirello commented 2 years ago

If you rebase onto master the Salus check should start passing

watsonian commented 2 years ago

Nice! The rebase fixed that. Everything looks good, but it needs one last code owner review before it'll let me merge.