search

DopplerHQ / cli

The official CLI for interacting with your Doppler secrets and configuration.
https://docs.doppler.com
Apache License 2.0
214 stars 43 forks source link

Use standard zsh path for rpm/RHEL releases #332

Closed mariaWitch closed 1 year ago

mariaWitch commented 1 year ago

Due to a quirk with OSTree releases, the rpm releases should place the doppler zsh completion file in /usr/share/zsh/, which is the default for Fedora/RHEL/CentOS based systems. In theory this should fix #331 but I will need to perform testing to confirm. There may be a more elegant way to accomplish this, but this seems to be the most straight forward way that I can find for the moment.

mariaWitch commented 1 year ago

Validated on Fedora CoreOS. zsh also autocompletes, so functionality is fully working.

mariaWitch commented 1 year ago

Validated on AlmaLinux. Going to do Fedora and then CentOS next. (These are non-OSTree based distros).

Update: Confirmed working on zsh on Fedora and CentOS Stream as well.

mariaWitch commented 1 year ago

@Piccirello Looking for review on this/the related issue.

Piccirello commented 1 year ago

Thanks for putting up this fix, and for testing across those different OSes! Could you squash the two merge commits so that this PR only has one commit? We can then get this merged in and released.

mariaWitch commented 1 year ago

@Piccirello Done.

mariaWitch commented 1 year ago

I believe I have solved the issue for why the e2e test was failing (it wasn't related to any of the changes, and was environment specific). If you could manually re-run the test on your end, it should pass now. @Piccirello

mariaWitch commented 1 year ago

I was able to get it to work on the forked repository with the correct secret values. So I don't understand why it isn't working here. It seems to be a github environment related issue though. image

mariaWitch commented 1 year ago

Same as before, just updated again.

Piccirello commented 1 year ago

This change has been released in CLI v3.45.0.