add support for the mini mote 2

SaidAlvarado commented 5 months ago

fixes #183

SaidAlvarado commented 4 months ago

I'm going to be honest, I have no idea why the CI is failing, specially the doc.

aabadie commented 4 months ago

I have no idea why the CI is failing, specially the doc.

The CI is now passing. There were 3 problems with the doc (fixed in ed7ea3d742dfc0a256822905c5d58420a6e3b021):

The doxygen group of the lh2 minimote application was duplicated and thus Doxygen was failing (this one was the error in CI, others came after it was fixed)
The new applications were not added to the Sphinx toctree
The new applications didn't contain any README and this is required by Sphinx. Please add some content there, that's always nice and is a good source of documentation.

I also fixed the Makefile so the right applications are built for the minimote. Also the minimote application is checked by the CI on nrf52833dk, nrf52840dk and nrf5340dk-app because they provide the required pin configurations.

Finally there was a misuse the timer API (did you try to build locally before pushing?), fixed in c33a2218925d98c081de86b2eb57a80dbb7925bc.

I also allowed my self to rebase on top the latest main branch because there was a merge commit of the main branch in the history. This was a pain to do. While I was at it, I reworded the commit comments (dropped all references to #183 and use lower case).

Can you double check that everything is working? because it was a tough rebase, I hope nothing got lost in the process.

aabadie commented 4 months ago

Please don't use git merge or a bare git pull ! It creates a merge commit like be8ba2b518b80cdddbfa8fcb94dc9f07cda2cfa9. It took me an hour to cleanup the history of that PR....

SaidAlvarado commented 4 months ago

Thanks for your help with this. I verified that the project works as expected. 👍

And indeed I found a bug with the ISM330 driver. I'm addressing it with #321.

DotBots / DotBot-firmware

add support for the mini mote 2 #316