search

DotModGroup / ColdWaters-DotMod

Cold Waters DotMod public repository
163 stars 22 forks source link

DotModInstaller on linux creates the wrong directory #43

Closed dimitargslavchev closed 3 years ago

dimitargslavchev commented 3 years ago

Version 0.2a beta

When invokng DotModInstaller.py on a linux machine (Ubuntu 20.04) it creates the wrong directory. Log is bellow.

Running the python installer creates the directory ..\MODS\DotMod\ColdWaters_Data (that is the name of the directory) inside the dotmod directory instead of in the Cold Waters directory.

Linux uses / instead of \ to delimate directories. As far as I know Windows does accept / as directory delimiter and will internaly change it to \, so changing \ to / in the script should work on both.

The .exe installer is fine and works well when ran with wine, though.

user@user-aspire:~/.steam/debian-installation/steamapps/common/Cold Waters/DotMod.v0.2a-beta$ python3 DotModInstaller.py 
Auto-locate failed.
Please input the directory of your Cold Waters install: ..
This will install DotMod to ... 
Is that correct? Y/N: y

Reminder: Only download DotMod from the GitHub page. Any other downloads are *unauthorized* and cannot be verified.
If you did not download the mod's files from the GitHub, close this program at once and run a malware scan.
Press Return to continue. 

Thank you for choosing DotMod! This program will help you automatically install/update the mod.
If you have JSGME installed, disable all mods currently enabled, and make sure the game is closed.
JSGME installed. Please read through JSGME Help.txt and JoneSoft.txt.
Working, please wait...
This may take some time.
Mod installed.

This program is completed. Now, navigate to your Cold Waters directory, at .., and run JSGME.exe (if you used Epic Mod, this may be called Epic Mod Install) and enable the main mod there.
Enable the main mod first, and then any addons you want over it.
Thank you for using DotMod.
user@user-aspire:~/.steam/debian-installation/steamapps/common/Cold Waters/DotMod.v0.2a-beta$ ls
ColdWaters_Data  DMEXE.ico  DotMod_0.2_Release_Notes.txt  DotModInstaller.exe  DotModInstaller.py  Installer.ini  JSGME
dslavchev@dslavchev-aspire:~/.steam/debian-installation/steamapps/common/Cold Waters/DotMod.v0.2a-beta$ ls -la
total 24792
drwxr-xr-x 5 dslavchev dslavchev     4096 сеп 19 12:02  .
drwx------ 5 dslavchev dslavchev     4096 сеп 14 23:12  ..
drwx------ 4 dslavchev dslavchev     4096 сеп 14 23:12  ColdWaters_Data
-rw-rw-r-- 1 dslavchev dslavchev    15086 авг 29 20:25  DMEXE.ico
-rw-rw-r-- 1 dslavchev dslavchev     8787 авг 29 20:25  DotMod_0.2_Release_Notes.txt
-rw-rw-r-- 1 dslavchev dslavchev 25325085 авг 29 20:25  DotModInstaller.exe
-rw-rw-r-- 1 dslavchev dslavchev     4222 авг 29 20:25  DotModInstaller.py
-rw-rw-r-- 1 dslavchev dslavchev       28 авг 29 20:25  Installer.ini
drwx------ 2 dslavchev dslavchev     4096 сеп 14 23:12  JSGME
drwx------ 4 dslavchev dslavchev     4096 сеп 14 23:12 '..\MODS\DotMod\ColdWaters_Data' # <- this is the name of the directory !!!
user@user-aspire:~/.steam/debian-installation/steamapps/common/Cold Waters/DotMod.v0.2a-beta$
HobbitJack commented 3 years ago

Wrote it for Windows machines. I used backslash, mostly because that's how I do everything else. That's on me. Will look at soon.

HobbitJack commented 3 years ago

@Tarkalak It should be fixed on the bleeding edge, if you could check for me. Thanks.

dimitargslavchev commented 3 years ago

Yep, now works.

HobbitJack commented 3 years ago

Epic! Closing.