search

Double0negative / xServerChat

5 stars 8 forks source link

Plugin ver 0.2.7 - Vault support + Bugfixes #4

Closed Stoolbend closed 11 years ago

Stoolbend commented 11 years ago

Added vault support, and fixed some bugs. Added a new permission node for sending of messages too. Tested compatible with CraftBukkit 1.5.1 R2

Bugfixes: Fixes Double0negative/xServerChat#3.

ghost commented 11 years ago

What does the plugin need Vault for? We're not adding permissions, merely checking for them.

EDIT: What I mean is, you can just use player.hasPermission. All permissions plugins work with that. If the one in use doesn't, then the server owner needs to install one that does.

Stoolbend commented 11 years ago

Well vault seemed the better choice last night as player.hasPermission() does not seem to work with pex and I would say that pex is one of the more widely used perm systems. If vault is not detected then it falls back to the player.hasPermission() mode. If you want me to replace with a pex only hook then I can do that but there is no point having perm nodes if no system can check them.

ghost commented 11 years ago

It actually does work.. no-one complains for me about my plugins, so I'd assume it works. I also test with mine, and SurvivalGames runs on play.mc-sg.org (double0's server) with PEX but no Vault, and it uses permissions.

Stoolbend commented 11 years ago

Mmh, it didnt work for me until I wrote the vault hook.

Anyway its merely an option for those who want to use it that may already use vault. (Like me :) )

If you would rather not give players the oppourtunity to use vault if they wish then I will remove it tonight, but im still gonna keep it in my adminchat branch as it works on my server. On 2 May 2013 07:24, "YoshiGenius" notifications@github.com wrote:

It actually does work.. no-one complains for me about my plugins, so I'd assume it works. I also test with mine, and SurvivalGames runs on play.mc-sg.org (double0's server) with PEX but no Vault.

— Reply to this email directly or view it on GitHubhttps://github.com/Double0negative/xServerChat/pull/4#issuecomment-17322348 .

ghost commented 11 years ago

Have you tested it with a different perms plugin and without Vault? If not, please do, because ClassNotFoundExceptions could occur.

Stoolbend commented 11 years ago

Yes I have tested with and without vault. If vault isnt enabled/on the server then it defaults back to the bukkit system. On 2 May 2013 07:47, "YoshiGenius" notifications@github.com wrote:

Have you tested it with a different perms plugin and without Vault? If not, please do, because ClassNotFoundExceptions could occur.

— Reply to this email directly or view it on GitHubhttps://github.com/Double0negative/xServerChat/pull/4#issuecomment-17322895 .

ghost commented 11 years ago

Ah, cool. Didn't know if there would be class not found exceptions. Merging.