DoubleDeez / MDFramework

A multiplayer C# game framework for Godot 3.4 Mono.
https://discord.gg/UH49eHK
MIT License
76 stars 13 forks source link

Clocked replication and OnScreenDebug #30

Closed Beider closed 4 years ago

Beider commented 4 years ago

I decided to make a pull request for this before I add more features, there are still outsanding features but this pull request is getting massive so I would like to merge this for now.

New features:

Beider commented 4 years ago

This fixes Fixes Issue #18 - On Screen Debug Fixes Issue #22 - Parameters for MDReplicated

Sadly Issue #17 is still not complete, there are a few outstanding things left. I could file a separate item for those so #17 could be closed if that is preferable over keeping it open?

Outstanding issues are:

I would like to switch from measuring how often updates are done from milliseconds to frames. So you say I want to update every 6 physics frames. Side effect would be replicator would be moved from idle frame to physics frame, is this bad? Are idle frames reliable? If game is very busy do idle frames still happen?

I added documentation for the new features here.

DoubleDeez commented 4 years ago

Yeah I think close #17 and opening new issues for each one makes more sense. I'm not too sure on the details of idle_frame, the main thing I wanted from it was to run code at the end of a frame so that we're sending RPCs as soon as possible but with interpolating and stuff it might not be as necessary so I'd be okay with moving to physics frames and offsetting by frame counts.

Beider commented 4 years ago

Alright I will change to physics frame when I fix the other issues that you will have for this pull request. I will open a new issue for each thing mentioned above so we can close #17. If you got time to do the review in the next days I got time to work on this over the next few days.

DoubleDeez commented 4 years ago

Sounds good. I'll look over it now

DoubleDeez commented 4 years ago

Just needs the typos fixed then I'll merge - thanks for doing all this!

DoubleDeez commented 4 years ago

Oh yeah, the README needs to be updated with the new files

Beider commented 4 years ago

Done, I fixed both of them now. Once you pulled it I will create a new request for the MDRpc changes.