search

DoubleDeez / MDFramework

A multiplayer C# game framework for Godot 3.4 Mono.
https://discord.gg/UH49eHK
MIT License
76 stars 13 forks source link

Code style improvements and visions #50

Closed Meister1593 closed 4 years ago

Meister1593 commented 4 years ago

I've made several code style changes over project (not including examples), also some converts (like for to foreach). I wanted to know what would be nice to apply in this project and what should be thrown away.

  1. Not sure about var, because sometimes it's useful (when you have obvious name of variable and long type with params), sometimes it's not really (replacing int with var in for-loop is a bit weird)
  2. I've moved vars declaration to the top, never seen vars at the bottom anywhere, so... maybe it's a good idea to move it ontop?
  3. Inverted some if's where it was obviously needed (too much spacing) and so on.
DoubleDeez commented 4 years ago

Going to review the updated changes now, but it looks like there's a merge conflict. I think it has to do with the way your first PR was done since for some reason this PR is trying to also add the same files and make the same changes. Looking at your code_style branch I see

This branch is 7 commits ahead, 1 commit behind DoubleDeez:master.

I'm not 100% on how to fix it, but you might need to git pull --rebase from my master branch into your code_style branch