Resolving private members & methods in inheriting classes - Githubissues

DoubleDeez / MDFramework

A multiplayer C# game framework for Godot 3.4 Mono.

https://discord.gg/UH49eHK

MIT License

77 stars 13 forks source link

Resolving private members & methods in inheriting classes #92

Closed Beider closed 3 years ago

Beider commented 3 years ago

When a class inherits from another our current code doesn't always resolve private methods in the class you are inheriting from. This is a problem for instance in MDGameInstance where OnSynchronizePlayer does not get resolved correctly if you have your own custom MDGameInstance.

This could potentially affect a lot of our MDStatics get method/member methods.

Add automated tests for all methods in MDStatics that resolve members/methods for all combinations of private/protected/public, static/not static and inherited/not inherited.
Fix any that do not work

Beider commented 3 years ago

Also add the same tests for custom classes using MDRpc (or MDReplicated) on custom classes that inherit from other custom classes with a few replicated members of varying visibility in the class it inherits from.