DouyinFE / semi-design

🚀A modern, comprehensive, flexible design system and React UI library. 🎨 Provide more than 3000+ Design Tokens, easy to build your design system. Make Semi Design to Any Design. 🧑🏻‍💻 Design to Code in one click
https://semi.design
Other
8.19k stars 695 forks source link

组件属性类型包含number,当该属性值设置成 NaN , 如果该属性值被用在componDidUpdate中,使用===判断是否更新,会导致页面 crach(比如select的value属性) #763

Closed YyumeiZhang closed 1 year ago

YyumeiZhang commented 2 years ago

Which Component 出现bug的组件

semi-ui version

Expected result 期望的结果是什么

Actual result 实际的结果是什么

Steps to reproduce 复现步骤

Reproducible code 复现代码

import React from 'react';
import { Select } from '@douyinfe/semi-ui';

() => (
    <>
        <Select value={NaN} style={{ width: 120 }}>
            <Select.Option value='abc'>抖音</Select.Option>
            <Select.Option value='hotsoon'>火山</Select.Option>
            <Select.Option value='jianying' disabled>剪映</Select.Option>
            <Select.Option value='xigua'>西瓜视频</Select.Option>
        </Select>
    </>
);

Additional information 补充说明

-

pointhalo commented 2 years ago

Components that require additional handling with isNaN (whose value supported number type)

edc-hui commented 1 year ago

我来修复这个问题