Closed adriangaro closed 3 months ago
What's the actual root
scope should random_owned_pop
be?
If anything no effect should change the scope of type of root and scripted effects with disjoint root scope should raise an error if they are mismatched
And please give an example for this validation / inspection
As you can see near the top near the scripted trigger definition started, the scope for root is planet.
Root scope never changes to my knowledge during a trigger, regardless how many scope changes happen in rest.
The actual scope for root for random_owned_pop
should remain unchanged and inherit the one from the place it was invoked then.
Seems to be a code error, ## push_scope
is used in related configs and it should be right.
Will be fixed in 1.3.6
In this image we can see the effect scope is planet for both
this
androot
butrandom_owned_pop
changes scope type ofroot
to pop, instead of maintaining the previousroot
scope type. If anything no effect should change the scope of type ofroot
and scripted effects with disjointroot
scope should raise an error if they are mismatched.Also
random_owned_pop
also changes scope ofprev
which should beplanet
, but the plugin sees it aspop
,random_owned_pop
changing this scope too, instead of changing it to previous scope.