DrakeVorndran / Canvas_Cellular_Automata

3 stars 0 forks source link

I am so not into... #8

Open soggybag opened 5 years ago

soggybag commented 5 years ago

https://github.com/DrakeVorndran/Canvas_Cellular_Automata/blob/dcb4e010400c3d69d28c1e79ec2c6952ab936e1d/index.html#L17

... these js function calls in HTML attributes. To be honest I'm not really sure whether this is best practice or not, I suspect not. I suppose you might say it couples your implementation to your HTML structure. It's probably more flexible in the long term to use an id and add a listener. Which you are doing in other places, which makes this look inconsistent.

I'll leave it up to you, but I recommend against this.