search

DrewLazzeriKitware / simulation-modeler

0 stars 0 forks source link

Keys need a home, but may change #21

Closed DrewLazzeriKitware closed 2 years ago

DrewLazzeriKitware commented 2 years ago

In order to build our Simput model (server/model/model.yaml), we need access to the pf-keys/definitions folder of the parflow/parflow repository. See diagram here for details.

Current (inadequate) solution:

Drew has a local copy of the parflow repository with changes that scripts/parflow/generate_model.py relies on.

Possible improvements

1) Push these changes to a fork of parflow. Pros: Shareable, simple. Cons: Parflow may update 2) Copy these changes into simulation-modeler repository. Pros: Keys readily available. Cons: Parflow may update 3) Push merge these into parflow/parflow. Pros: No need to merge later. Cons: Coordinating a review with parflow/parflow

DrewLazzeriKitware commented 2 years ago

Let's move pf-keys and pftools to a submodule, so that we can contribute back easily, we don't get out of sync between simput and pftools, and we have everything under this repo.

DrewLazzeriKitware commented 2 years ago

submodule vs subtree?

DrewLazzeriKitware commented 2 years ago

I've forked parflow at github.com/DrewLazzeriKitware/parflow, pushed the key changes there, and added it as a submodule for this repository.