Some stuff in the UWP version

[Guerra24]

New report will be added as a reply to this issue. Please do not close this issue. UWP edition of #121.

Icons:

• 🐞 Bug - It doesn't do what it's supposed to do, required to fix (feature issues, crashes)
• 🐝 Bee - I want it to look better, not required to fix (ui, animation, etc)
• 🍄 Mushroom - Feature Request/Suggestion
• 💙 Blue Heart - I like it! General Feedback

Feel free to edit.

---

• 🐞 Typo in "sort values".
  • ✔️ Fixed
• 🐝 Highlight is way too transparent.
  • ✔️ Fixed
• 🍄 Move the back arrow to the window frame.
  • ✔️ Fixed
• 🐝 Images in articles should be cropped or scaled instead of stretched (it looks bad).
  • ✔️ Fixed
• 🐝 Bottom bar position; left is how looks now, right is how it should be. Image
  • ✔️ Fixed
• 🐝 The bottom bar changes color in the "Images" view.
  • ✔️ Fixed
• 🐞 Going into "Anime recommendations" crashes the app (Fix ASAP).
  • ✔️ Fixed
• 🍄 Make the Title Bar use the accent color, only when the window is active.
  • ✔️ Use acrylic
• 🐝 Scrollbar arrows still appear even if the list does not exceed the max size. Vid. This is in the "History" view.
  • ✔️ Fixed
• 🐝 With some accent colors the highlight makes the text impossible to read.
• 🐝 Scrollbar should stick to the window border. Now, how it should
  • ✔️ Fixed
• 🐝 Anime images (right side) should be cropped or scaled instead of stretched (it looks bad).
  • ✔️ Fixed
• 🐝 Calendar highlight doesn't mach and the icon doesn't move with the background. Video
  • Well, I see why.
• 🐝 Closing the settings doesn't restore to the previous selected item in the hamburger menu. Video
• 🐞 Clicking an item multiple times will reload the view even if it is already loaded. Video
• 🐝 Drag to increase/decrease uses all available mouse buttons, some of them (middle click or custom) doesn't trigger the click animation.
  • UWP Bug...
• 🐞 Missing delete button when adding new anime to list. Video
• 🐞 The "clear image cache" is ultra slow and gets cancelled when the app is closed.
• 🍄 Use the entire button for the date selector. Video
• 🐞 Season selector partially broken. Video
• 🐞 Character name with special "symbols". Image
• 🐞 Forum posts broke. Image
  • ✔️ Fixed
• 🐝 Why not integrate the top area (hamburger button, list name and anime name) into the titlebar?
  • ✔️ Implemented.

[Drutol]

I'll do this on Friday probably, where can I order 2nd pair of hands? ;d

[Drutol]

Update: well I've caught a cold and I was unable to do anything today :(

[Guerra24]

The Anime recommendations crash still happens, at least for me. Vid

[Drutol]

Does window size has anything to do with recommendations crashing?

[Guerra24]

No, maximized or any other size still crashes.

[Drutol]

And it changes to the different mode when it has more space before crash?

[Guerra24]

Yes, if maximized it shows the bottom bar.

[Drutol]

Hmm, is any of these devices yours?

[Guerra24]

No, I'm using a custom pc.

[Guerra24]

I would say that the UWP app is broken, since I have some free time I will start working on fixing this. I don't know much about UWP but have used C# in the past.

[Drutol]

Yes, I've fixed this but I was waiting on feedback regarding freezes so I didn't push an update yet.

[Guerra24]

I mean, fix all they issues listed here.

[Drutol]

Oh okay, good luck, getting some help would be huge booster ^^ I was on my phone so I couldn't edit it as I usually do.

[Guerra24]

The resizing crash... Visual Studio is unable to handle the exception, I'm unable to debug this crash. Looks that is something in the win32 side, way below in the system. SO, this bug is here from the beginning (most probably) or was introduced with an update.

[Guerra24]

The anime list system isn't the issue, it works correctly. There is something that gets triggered at a specific size.

[Drutol]

Noooo please no... I've been fighting with this once for a long time... in the end it turned out that for some reason pivot with "Watching,Completed" etc was causing it when its index was set via binding. It was pure luck back then.

No wonder crash reporting isn't helpful...

[Guerra24]

And the "Anime recommendations" crash caused by an "Access Violation Exception"

[Drutol]

Pivot again...

[Drutol]

Try removing custom styles from these pivots?

[Drutol]

How is it going?

[Guerra24]

Now I hate visual studio, just saying xD. The VS project system is awful.

[Guerra24]

And yes, removing the custom styles fixes the crash. Video

EDIT: After some testing the source of the crash are the Selection States, removing that code fixes the crash.

EDIT2: Recommendations crash is the same, removing the selection states fixes it. Video

[Drutol]

Well I don't see any issue with project structure in vs. For me the java one is much more messy.

Vs is mediocre without ReSharper though.

I'll look into it today, thanks! ^^

[Drutol]

Hmm I was unable to check it out because "android open beta"... I will though as soon as I can

[Drutol]

It looks like MS changed pivot style completely with some update...

[Drutol]

I want to rewrite everything so badly now that I see some things that were here from day-one, god what monstrosity is this...

[Drutol]

Nothing has changed in HeaderItem which has these styles though...

[Drutol]

They won't work because I don't have the data yet while arranging these items, once the data is here notice that they are sorted correctly.

[Guerra24]

mmm... if that's the case, it needs the "Load all details" button or triggering the "load details" when sorting.

[Drutol]

It would require too many requests, if user wants to have everything pulled he just needs to:

[Guerra24]

The "Load all details" is not available in search mode.

[Drutol]

Hmm it was hidden as it was useless in certain contexts and I seem to have missed valid ones... Fixed

I'm planning to push UWP update today.

[Drutol]

I wonder whether MSFT fixed these issues with freezing somehow.

[Drutol]

Wat. It always happens?

[Guerra24]

Yes, it's consistent. Go into plan to watch, then sort by season, scroll down then scroll up will trigger it.

[Drutol]

You just have broken computer... crashes on resize, memory leaks... it all works for me.

I don't know even where to start to fix it. Maybe you could ran memory profiling in visual studio. It has nice stats how many objects are allocated.

[Guerra24]

"It's all on my mind" xD. I'm going to do some testing and try on a friend's pc, just in case you're right.

[Guerra24]

@Drutol, What version of Visual Studio do you use?

[Drutol]

2017 Community (15.2)

[Guerra24]

• 🐞 Forum posts broke.

[Drutol]

This is on new update?

[Guerra24]

Yes.

[Drutol]

Got it, fixed.

[Guerra24]

• 🐝/🐞 Notify user in case of pending approval.

  

[Drutol]

Hmm I'm not sure whether MAL returns generic error here or states the reason...

[Guerra24]

💙 Unexpected update, love it ❤️

[Drutol]

You're welcome :D

I really hate your brown accent colour ^^ Could be good idea, I'll try it out someday.

[Guerra24]

~I've imported the project in VS but the shared project fails to compile, is there an extra step to make it compile?~

EDIT: Never mind, downgraded the Microsoft.NETCore.Portable.Compatibility package from 1.0.2 to 1.0.1 and it worked.

EDIT2: What is this Secrets.cs file?

[Drutol]

151 #165

[Guerra24]

Thanks! 👍