search

Dwolla / dwolla-v2-ruby

Official Ruby Wrapper for Dwolla's API v2
https://developers.dwolla.com/
MIT License
22 stars 17 forks source link

Provide support for Faraday 2.0 #70

Closed elbowdonkey closed 1 year ago

elbowdonkey commented 1 year ago

This allows the Dwolla_v2 gem to work with the latest Faraday.

elbowdonkey commented 1 year ago

@jcoon97 can you re-approve and merge? I'm not able to merge it.

ShreyaThapa commented 1 year ago

Thanks so much for the PR @elbowdonkey! 🙌 Just merged your changes to main. We will get this versioned and published to RubyGems soon! 👍

elbowdonkey commented 1 year ago

Thanks! Looking forward to seeing it released. Let me know if I can help in any way.

ShreyaThapa commented 1 year ago

Hi @elbowdonkey, apologies for the delay in publishing the release to RubyGems. While the PR looked ok, it appears our automated tests have failed upon merging to main due to compatibility issues with some older Ruby versions. We want to prioritize maintaining compatibility with a wide range of Ruby versions. This is important to ensure that our gem remains accessible and functional for all users, including those who may be using older Ruby versions.

We just need to conduct additional testing to ensure compatibility. Depending on the results, we may need a major version bump. Hoping to publish this early next week!