search

DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
334 stars 187 forks source link

Floor creation node #1358

Open ksobon opened 7 years ago

ksobon commented 7 years ago

This came up on the forum:

I feed closed PolyCurve to this node and it makes floor ok. Then, I try modifying using SlabShapeEditor, and always one point doesn't work and remains at 0 level. If I edit the floor sketch it reveals that the floor creation node adds a Span Direction Edge when making floors, and this messes up the slab shape. Two questions: 1) does someone have a better, python floor node that doesn't have this problem? And 2) can we delete Span Direction Edge from the floor sketch with Python?

I guess there is an issue with the Floor.ByCurves node.

https://forum.dynamobim.com/t/floor-byoutlinetypeandlevel-makes-floors-with-span-direction-edge/6935

kronz commented 7 years ago

Thanks @ksobon @moethu any thoughts?

moethu commented 7 years ago

thanks @ksobon will look into this. could you supply your definition? Should we add the span/slope properties?

ksobon commented 7 years ago

@moethu this isn't my definition. It came up on the Dynamo Forum but looks like something that should belong here and be discussed with the devs. Can you please follow the link that I posted and perhaps respond on the forum?

moethu commented 7 years ago

@kronz @mjkkirschner just realized that my PR (https://github.com/DynamoDS/DynamoRevit/pull/1345) regarding this features hasn't been pulled yet. So I'm not sure what slabshape edit nodes we are talking about here.

andydandy74 commented 7 years ago

@moethu - Probably the one in Clockwork (Floor.SlabShapeByPoints).