search

DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
336 stars 187 forks source link

Levels selection node causes Level.Elevation parameter to become unresponsive #1411

Open ThomasMahon opened 7 years ago

ThomasMahon commented 7 years ago

Dynamo version

1.2

Revit version

Revit 2016

Operating system

Win 10

What did you do?

Used the Levels selection node from the Dynamo Revit library. Extracted the elevation height using Level.Elevation and updated the height of the Level in Revit manually.

What did you expect to see?

For Dynamo to dynamically update the Level.Elevation output whenever changes to the level height were made in the Revit model.

What did you see instead?

The Level.Elevation fails to update. I also tried using Element.GetParameterByName as a workaround and it also fails to update. The only way I've found that works as expected is to use All Elements of Type then extract the level elevation:

image

It seems then, that the Levels selection node is the cause of the problem

ksobon commented 7 years ago

@mjkkirschner what are your thoughts on this? I think I remember that back in the days we used to have ElementsUpdated event on all dropdown nodes, but that was getting us into infinite loops. Do I remember that correctly or was it something else? Should we add that to the DSDropDownBase?

ksobon commented 7 years ago

So if we were to add that event it would potentially behave like so:

https://drive.google.com/file/d/0B3QQaPkepGSkT3prbXFZQzNhNFE/view

mjkkirschner commented 7 years ago

@ksobon I think you're remembering correctly - we can try to find the PR where it was potentially removed, probably for the issue of getting into infinite loops quite easily.

ksobon commented 7 years ago

You think you can dig it up to refresh our memory and make sure we are not imagining this. Then i guess it can be closed.