search

DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
339 stars 188 forks source link

Element.Geometry CRASHES with nested families #2181

Open ColinDayOrg opened 6 years ago

ColinDayOrg commented 6 years ago

Issue by epeter- Tuesday Feb 03, 2015 at 18:38 GMT Originally opened as https://github.com/DynamoDS/Dynamo/issues/3679

replaces the issue with 3000+ elements causing a crash. found out that it is not the number of elements causing revit to crash but nested families. i created a showcase file that is available for download under following link: https://www.dropbox.com/s/gmlixa38olx7nt2/lifting.rvt?dl=0 i will remove the link in 2 hours from now.

ColinDayOrg commented 6 years ago

Comment by tatlin Tuesday Feb 03, 2015 at 19:42 GMT

@jnealb or @hlp please take a look. cc @RodRecker @kronz

ColinDayOrg commented 6 years ago

Comment by ptierney Tuesday Feb 03, 2015 at 19:57 GMT

Hi @epeter- I've received your file and will look into it in a bit

ColinDayOrg commented 6 years ago

Comment by kronz Tuesday Feb 03, 2015 at 20:43 GMT

Something odd going on with the specific geometry in the nested family.
2015-02-03_1541 Guessing that it has to do with the form itself being made into a closed shape, which Revit often does not like 2015-02-03_1539

ColinDayOrg commented 6 years ago

Comment by kronz Tuesday Feb 03, 2015 at 20:53 GMT

@hlp @epeter- I don't see the crash (working in Daily builds). But I also don't see the looped nested elements coming through from Element.Geometry. The element itself is an odd one, seems like it's not a well formed solid 2015-02-03_1552

ColinDayOrg commented 6 years ago

Comment by epeter- Tuesday Feb 03, 2015 at 21:06 GMT

@kronz i too found out that it is the hook causing all the troubles. to import the geometry into dynamo you will need Clockwork (Revit/Elements/FamilyInstances/FamInstSubStructure) that will import nested families

ColinDayOrg commented 6 years ago

Comment by ptierney Tuesday Feb 10, 2015 at 01:24 GMT

Hey @epeter- , @tatlin :

I looked into this. The main problem is that the class Autodesk.Revit.DB.RevolvedFace class doesn't provide the sweep parameters for a revolved surface. In other words, we know that those pipe elbows are surfaces of revolution, but have no way of determining that they're only swept 90 degrees. Because of this, we default to a complete revolution, producing circles (as shown in @kronz 's images).

It might not be possible to solve this without something like an import instance.

ColinDayOrg commented 6 years ago

Comment by epeter- Tuesday Feb 10, 2015 at 22:35 GMT

maybe at least throw an exception to avoid crashing?

ColinDayOrg commented 6 years ago

Comment by ptierney Tuesday Feb 10, 2015 at 23:08 GMT

I actually can't reproduce the crash: I get the same results as Zach, an exception. Are you on the daily build?

ColinDayOrg commented 6 years ago

Comment by epeter- Wednesday Feb 11, 2015 at 07:33 GMT

i get an exception too, but the exception causes revit to crash. no, i am still on the last 2014 build, as select model element(s) does not work in 2015 dailies

Am 11.02.2015 um 00:08 schrieb Patrick Tierney:

I actually can't reproduce the crash: I get the same results as Zach, an exception. Are you on the daily build?

— Reply to this email directly or view it on GitHub https://github.com/DynamoDS/Dynamo/issues/3679#issuecomment-73804126.

Diese E-Mail wurde von Avast Antivirus-Software auf Viren geprüft. http://www.avast.com

ColinDayOrg commented 6 years ago

Comment by aparajit-pratap Wednesday Jun 08, 2016 at 08:37 GMT

http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-10222