DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
334 stars 187 forks source link

Dimension.Value returning internal units instead of display units #2280

Open andydandy74 opened 5 years ago

andydandy74 commented 5 years ago

Dynamo version

2.0.1 stable

Revit version

Any

Operating system

Windows 10

What did you do?

Tried to retrieve the value of a selected dimension using Dimension.Value

What did you expect to see?

What did you see instead?

mjkkirschner commented 5 years ago

it appears https://github.com/DynamoDS/DynamoRevit/blob/Revit2019/src/Libraries/RevitNodes/Elements/Dimension.cs#L213

does not use the host unit converter... 😢

mjkkirschner commented 5 years ago

for example - when an element's parameter is queried https://github.com/DynamoDS/DynamoRevit/blob/94be25ae025e4372841db50cf3c4edb255652a78/src/Libraries/RevitNodes/Elements/InternalUtilities/ElementUtils.cs#L104

not really sure why ints are not also converted? @aparajit-pratap ?

mjkkirschner commented 5 years ago

@QilongTang @AndyDu1985 - whats the best way to get these github issues into the revit backlog?

aparajit-pratap commented 5 years ago

Not sure. I think @ksobon should have a better idea.