search

DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
334 stars 187 forks source link

CurtainPanel.ByElement unreliable #2302

Open andydandy74 opened 9 years ago

andydandy74 commented 9 years ago

As shown in the screenshot below, CurtanPanel.ByElement returns null as soon as a curtain wall contains door or window elements (which, in my experience, is typically the case). Nested wall elements or curtain walls luckily pose no problem. cwp_limitations As a first step, it would be great to not have the node fail to deliver those elements that are not doors or windows if such elements are present. As a second step, it would be even better if doors or windows could also be returned. It makes a lot more sense to have a full inventory of all elements in a curtain wall/system. Also, in 0.7.5 walls and curtain walls are actually being returned as belonging to the Walls category, not as Curtain Panels. That wasn't such a bad thing because it allows for easy filtering of the results...

andydandy74 commented 9 years ago

Example files posted here: https://github.com/CAAD-RWTH/ClockworkForDynamo/tree/master/issues/4128_CurtainPanel.ByElements%20unreliable

pboyer commented 9 years ago

@kronz

On Mon, Mar 30, 2015, 5:18 AM Andreas Dieckmann notifications@github.com wrote:

Example files posted here:

https://github.com/CAAD-RWTH/ClockworkForDynamo/tree/master/issues/4128_CurtainPanel.ByElements%20unreliable

— Reply to this email directly or view it on GitHub https://github.com/DynamoDS/Dynamo/issues/4128#issuecomment-87606668.

kronz commented 9 years ago

Tracking internally as http://adsk-oss.myjetbrains.com/youtrack/issue/MAGN-6859

andydandy74 commented 9 years ago

In case anyone else runs into this problem while this bug is still active: I needed this urgently so I went ahead and made this as a custom node. Available as Element.Panels in package Clockwork.

andydandy74 commented 9 years ago

Another small addition: When we use wall elements as curtain panels, Revit actually seems to store two elements: a curtain panel placeholder and the actual wall element that appears in the panel schedule. When we collect curtain panels in Dynamo by category we will, however, receive the placeholder element – which means we do not get those elements that will actually appear in a panel schedule. This can be remedied by querying panels for their host panels with the FindHostPanel() method. This method will return the actual wall element (the placeholder elements are quite useless). For normal CW panels it should return null if memory serves correctly. For more information on how this currently impedes workflows refer to this discussion: http://dynamobim.com/forums/topic/host-issuequestion/

ParametricMonkey commented 6 months ago

Still an issue some 9 years later...https://github.com/DynamoDS/DynamoRevit/issues/3043