search

DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
336 stars 187 forks source link

Material by Name wrong category #2533

Open gschleusner opened 9 years ago

gschleusner commented 9 years ago

This seems to be in the wrong category. This is a Query node not a create.

dynamomaterial

monikaprabhu commented 9 years ago

@gschleusner, Thanks for reporting this issue - its internally tracked at -MAGN-6419

kronz commented 9 years ago

Hi @gschleusner Revit API needs a non-human readable name for materials, that are extracted on a per-document basis. So, the API name for "Glass" might be "26". So, given a string, this node returns the needed material name. Query generally is used to extract infomation from an entity that has lots of other kinds of information, but this particular node creates information specific to a kind of entity from a string. 2015-03-08_0933

monikaprabhu commented 9 years ago

@gschleusner ,@Zach, With Zach's explanation I guess the it makes sense not to put the node into query. But the method does not allow to create new material from Dynamo. So if we keep this under create it would be confusingg. This action is returning material, which is equivalent to selection of Entities. And all selection nodes are under Action category. Perhaps we can move this into Action? @gschleusner, will that solve your issue?

dbaldacchino commented 9 years ago

I just had the same issue (filed a new case and @andydandy74 kindly crosslinked me here). Greg and I never talked about this, yet I also think of this as a "Query" since what it's doing is looking up the material name as a string to see if it exists. Action would be the second best place but I still think Query is the most natural descriptor of what this does, regardless of the technical API reasons. "Create" is most definitely not what this node does.

ZiyunShang commented 4 years ago

Does the latest DynamoRevit still have this problem? I couldn't find the category, just a node - "Revit->Elements->Material.ByName".