search

DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
328 stars 184 forks source link

ImportInstance.ByGeometry Incorrect Scale and Transforms #2689

Open karambk opened 3 years ago

karambk commented 3 years ago

If this issue is not a bug report or improvement request, please check the Dynamo forum, and start a thread there to discuss your issue.

Dynamo version

2.10.1 Shipped with Revit 2022

Revit version

Revit 2022

Operating system

Windwos 10

What did you do?

Using ImportInstance.By Geometry or ImportInstance.By Geometries

What did you expect to see?

Incorrect Scale and Incorrect Transforms

What did you see instead?

Correct Scale and Transforms

Screenshots

Incorrect Transforms Screenshot_Incorrect_Transforms (1)

Incorrect Scaling By Different document units Screenshot_Incorrect_Scaling (1)

File

Scaling and Transform DYN and SAT File.zip

Report to Autodesk

I just reported them with the following Ids: RVTPR-00802 RVTPR-00803

I expect ImportInstance.By Geometry is broken like this in Revit 2022 due to document.import change happened, which is undocumented actually anywhere.. as the new method uses ShapeImporter code, instead of an old unmaintained code. And ShapeImporter doesn't require scaling or transforming to get the geometry right. Therefor, a change is urgently needed in ImportInstance.By Geometry and ImportInstance.ByGeometries Dynamo For Revit Nodes.

ZiyunShang commented 3 years ago

Hi @karambk , we have already create a jira task tracking this issue - https://jira.autodesk.com/browse/REVIT-176082

karambk commented 3 years ago

Hi @ZiyunShang yes, Jie told me so on the report platform. Thanks.

BurcuOlcer commented 2 years ago

Hi, @karambk I have the same problem now, I checked the ' https://jira.autodesk.com/browse/REVIT-176082' page but couldn't find a solution for it. Could you solve your problem? Thanks

karambk commented 2 years ago

@BurcuOlcer I'm not sure, but I think they solved this specific issue in a recent update.. @ZiyunShang ?

But anyways, you'll face tons of other issues with geometry translation, especially in the latest ShapeImporter API decision and removal of document.import old internal code without supporting similar healing techniques in the ShapeImporter.

So, after loosing hope, I created something to at least remedy a good number of these geometry translation issues.

Long story: https://forum.dynamobim.com/t/familyinstance-bygeometry-not-working-in-revit-2022/64469/43

Short story: Just install Synthesize toolkit and use K-Family Import node. or use Dynamo Geometry To Revit Compatibility node, they essentially both works the same, but one of them imports as a family, and the other imports as ImportSymbol or FreeForm or DirectShape (Based on your inputs and if you're in a family or a project)

ZiyunShang commented 2 years ago

Hi @karambk @BurcuOlcer , sorry for late response. This issue has been fixed by Revit team, and released in Revit 2023 now. You can try the new Revit version 2023.

BurcuOlcer commented 2 years ago

@karambk thank you so much! K-Family Insert node worked for me. It gained me so much time, I can go new phase for my thesis now, and @ZiyunShang thanks you too, since I use the educational version, 2023 is not available for me right now.