DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
334 stars 187 forks source link

Unable to convert RuledFace to ProtoType geometry #2731

Open dronov-dmitry opened 3 years ago

dronov-dmitry commented 3 years ago

Have a problem with "RuledFace" geometry. ErrorWrite : "Значение не может быть неопределенным.: Имя параметра: revitCurve" Dynamo version - 2.0.4 Windows 10 This element is showing like this : изображение

github-actions[bot] commented 3 years ago

Hello dronov-dmitry, thank you for submitting this issue! We are super excited that you want to help us make Dynamo all that it can be. However, given that there has been no additional information added, this issue will be closed for now. Please reopen and provide additional information if you wish the Dynamo team to investigate further.

Additional information:

QilongTang commented 3 years ago

@RobertGlobant20 Seems our bot will mistakenly close user created issue like this?

mjkkirschner commented 3 years ago

I think this is a DynamoRevit GeometryConversion issue and should be transferred to DynamoRevit repo - @ZiyunShang fyi.

mjkkirschner commented 3 years ago

@dronov-dmitry please provide steps to reproduce (rvt, code, .dyn file etc)

dronov-dmitry commented 3 years ago

https://disk.yandex.ua/d/tEQQ30ULIDoWYQ https://disk.yandex.ua/d/C92Lu_8fwMq57w изображение

mjkkirschner commented 3 years ago

would guess it makes sense to start looking: https://github.com/DynamoDS/DynamoRevit/blob/master/src/Libraries/RevitNodes/GeometryConversion/SurfaceExtractor.cs#L239

ZiyunShang commented 3 years ago

As Michael guessed, an error occurred there. For your RuledFace, face.get_Curve(0) returned null, and face.get_Curve(1) returned a Arc line. For the current code, it can't create a Dynamo Surface here.

ZiyunShang commented 3 years ago

Hi @mjkkirschner , for this Geometry, its profile in Revit is composed of three surfaces, as shown. SideFace As you can see, the surface consists of a triangle and two symmetrical plane geometry with a quarter circle. For the plane geometry with a quarter circle, it only gets one edge through Revit api - get_curve : OneCurvePlane Is this can be converted to Dynamo Geometry?