DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
333 stars 186 forks source link

Point.PruneDuplicates Inconsistent Units #2740

Open karambk opened 2 years ago

karambk commented 2 years ago

Dynamo version

2.10

Revit version

Revit 2022

Operating system

Windows 10

What did you do?

Used Point.PruneDuplicates

What did you expect to see?

Points being pruned at a tolerance using the same display units of the current active project

What did you see instead?

Points being pruned at a tolerance using Feet units regardless of the current active project

Notes

All Dynamo for Revit versions used tolerance value as the same display units of the current active project, changing this behavior in Revit 2022 breaks so many older workflows

karambk commented 2 years ago

@Amoursol Hey Sol, it's been a while :)

Beside that, Is this change intended ? will it stay like that ? I need to know in order to edit my scripts accordingly. Thanks :)

Amoursol commented 2 years ago

@ZiyunShang this appears to be another regression in D4R - is it possible to investigate?

ZiyunShang commented 2 years ago

Hi @Amoursol , this node is a Dynamo Geometry node, I can't find its code on my side. But I guess it may be impacted by Revit UnitType API changes.

Amoursol commented 2 years ago

@ZiyunShang Ah, yes probably 😢 @aparajit-pratap do you think this is the case and can we take a look?

karambk commented 2 years ago

@ZiyunShang @Amoursol @aparajit-pratap I made a bit of investigation, it seems that if the points are generated inside dynamo, they are pruned with tolerance using display units

But if the points are grabbed by the location of Revit element, they are pruned using internal units feets

It's complicated

Previously, no matter what's the way we generate the points, the pruning worked using display units.

Hope that helps.

Amoursol commented 2 years ago

@QilongTang - Based on what Karam wrote above, do we think this lies on our side? Or on D4R?