Open jmcouffin opened 2 years ago
FYI: @DynamoDS/dynamo
While trying to edit a custom node containing ironpython code:
La référence d'objet n'est pas définie à une instance d'un objet.
à Dynamo.WorkspaceDependency.WorkspaceDependencyView.DependencyRegen(WorkspaceModel ws)
à Dynamo.WorkspaceDependency.WorkspaceDependencyView.OnWorkspaceChanged(IWorkspaceModel obj)
à System.Action`1.Invoke(T obj)
à Dynamo.Extensions.ReadyParams.OnDynamoModelPropertyChanged(Object sender, PropertyChangedEventArgs e)
à System.ComponentModel.PropertyChangedEventHandler.Invoke(Object sender, PropertyChangedEventArgs e)
à Dynamo.Models.DynamoModel.OnPropertyChanged(String propertyName)
à Dynamo.Models.DynamoModel.OpenCustomNodeWorkspace(Guid guid)
à Dynamo.ViewModels.DynamoViewModel.FocusCustomNodeWorkspace(Guid symbol)
à Dynamo.ViewModels.DynamoViewModel.GoToWorkspace(Object parameter)
à Dynamo.Controls.NodeView.topControl_MouseLeftButtonDown(Object sender, MouseButtonEventArgs e)
à System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
à System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
à System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
à System.Windows.UIElement.ReRaiseEventAs(DependencyObject sender, RoutedEventArgs args, RoutedEvent newEvent)
à System.Windows.UIElement.OnMouseDownThunk(Object sender, MouseButtonEventArgs e)
à System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
à System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
à System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
à System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
à System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)
à System.Windows.Input.InputManager.ProcessStagingArea()
à System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
à System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
à System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
à System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
à System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
à MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
à MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
à System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
à System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)
@mjkkirschner @QilongTang Another case of the collapsed nodes on top of each other.
@jmcouffin quick question - was Dynamo Player or the Dynamo CLI involved in this process at all?
There are many of these cases - I can't dig one up at the moment - but I would try disabling pyRevit and other revit addins as a starting debug step.
Next Dynamo packages and check if it reproduces, there are many warnings in the log about potential version conflicts with xceed.
@Amoursol nope. @mjkkirschner I did just that, after posting the issue, to no avail.
The script is working in revit 2019,2020 and 2021 with latest patch
And it did open properly before the latest Revit 2022 patch
Can you provide the file? What version of Revit exactly? You can also try disabling adsk addins in Revit as a next step.
And Finally...
I found what did mess up the whole thing. At least found the fix. I had the generative design packages (that comes with dynamo/revit) scheduled for uninstall (as I did not use them, I figured I would get them out of the way the first time I setup Revit 2022.
And all came back to normal.
Code blocks, organization, groups ans colors
I then tried to bring back all the addins and did try the script again. And all was well...
@saintentropy @nate-peters Were you aware of such issue?
hmm - I blame system.windows.interactivity, GD seems to reference a newer version than revit or dynamo - a similar issue here: https://github.com/eirannejad/pyRevit/issues/1101#issuecomment-813516295
I think Konrad points out the potential problem, and I believe we have this tracked, somehow our nuget brings in a transitive dep dll that people end up referencing, and it's different from the version we or Revit actually ship.
I think the task thats filed suggested just getting rid of this whole dep and internalizing the code, because it's been open sourced, and the number of repeat bugs and conflicts this library causes is a drain on us and users.
FYI @jasonstratton @QilongTang https://jira.autodesk.com/browse/DYN-3573
in the mean time @nate-peters you can try aligning versions of system.windows.interactivity - if we can reproduce this with the @jmcouffin's graph.
@jmcouffin - I do want to clarify something though - you say you had the GD packages marked for uninstall - did removing GD fix the issue, or did putting GD back fix the issue? Can you explain your steps with a bit more detail?
@jmcouffin - I do want to clarify something though - you say you had the GD packages marked for uninstall - did removing GD fix the issue, or did putting GD back fix the issue? Can you explain your steps with a bit more detail?
sure @mjkkirschner, pretty simple Cancelling the 'mark for uninstall' did the trick. I did not removed the GD (marking it for uninstall did not do anything for months _ I did mark it last april and did not touch dynamo too much in revit 2022 in the meantime)
Dynamo version
Core 2.12.0.5650 Dynamo Revit 2.12.0.5740
Operating system
win 10 pro in french
What did you do?
opened a script that works in Revit 2021
What did you expect to see?
everything as usual in the graph
What did you see instead?
Journal file portion of interest
attach dynamo log dynamoLog_8bde883d-0d6c-4c35-b56e-5bb13453ea3e.txt
Code block not showing any text![image](https://user-images.githubusercontent.com/7872003/137143974-bd0e488b-b918-45bb-8adf-55a1bd93cea1.png)