Closed awbushnell closed 2 years ago
@ShengxiZhang FYI
As there are many changes, I think we can use CrsTest to run a d4r regression test first, build this branch and copy them to revit addins.
@wangyangshi I have run CrsTest to run all 381 regression tests for D4R, and all test pass with these changes! In addition I used the debug mode to force ElementId's into the 64Bit range we have and with that on, all tests for D4R ALSO Pass now. So it seems D4R is in much better, if not mostly set for 64-bit ElementId. Can we get this merged and a new package produced to integrate into Revit?
Please Note:
DynamoRevit
repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after aLGTM
label is added to the PR.Purpose
Revit 2024 is upgrading ElementId, BuiltInCategory and BuiltInParameters to be 64-bit long types. Dynamo For Revit needs to be updated to account for this:
Declarations
Check these if you believe they are true
*.resx
filesReviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR) @wangyangshi
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of