rookiogmailcom commented 2 years ago

Issue Description

Please fill in the following information to help us reproduce the issue:

What did you do?

Create graph to try and modify ViewTemplate Category visibility settings - click run (manual mode)

What did you expect to see?

View Template category to change visibility status in revit

What did you see instead?

No change to visibility status and crash report from dynamo (Arrrgh!)

What packages or external references (if any) were used?

Clockwork for Dynamo 2.x 2.4.0 Rhythm 2022.7.2

Revit 2021.1.7 Dynamo Core 2.6.2.1.15705 Dynamo Revit 2.6.2.15772

I Was previously using Clockwork 2.3.0 and rthythm 2020.9.8 (I updated to latest package versions in order to check if any difference to the error, same thing ocurred using new and old version of packages)

Stack Trace

Object reference not set to an instance of an object.

   at Autodesk.Revit.DB.Category.get_Id()
   at Revit.Elements.Category.get_Id()
   at Revit.Elements.Category.GetHashCode()
   at System.Collections.Generic.Dictionary`2.Remove(TKey key)
   at ProtoFFI.CLRObjectMarshaler.OnDispose(StackValue dsObject, Context context, Interpreter dsi)
   at ProtoFFI.DisposeFunctionPointer.Execute(Context c, Interpreter dsi, List`1 s)
   at ProtoCore.Lang.FFIFunctionEndPoint.Execute(Context c, List`1 formalParameters, StackFrame stackFrame, RuntimeCore runtimeCore)
   at ProtoCore.CallSite.ExecWithZeroRI(List`1 functionEndPoint, Context c, List`1 formalParameters, StackFrame stackFrame, RuntimeCore runtimeCore, SingleRunTraceData previousTraceData, SingleRunTraceData newTraceData, FunctionEndPoint finalFep)
   at ProtoCore.CallSite.Execute(List`1 functionEndPoint, Context c, List`1 formalParameters, List`1 replicationInstructions, StackFrame stackFrame, RuntimeCore runtimeCore)
   at ProtoCore.CallSite.DispatchNew(Context context, List`1 arguments, List`1 partialReplicationGuides, DominantListStructure domintListStructure, StackFrame stackFrame, RuntimeCore runtimeCore)
   at ProtoCore.DSASM.Executive.Callr(Int32 blockDeclId, Int32 functionIndex, Int32 classIndex, Boolean& explicitCall, Boolean isDynamicCall, Boolean hasDebugInfo)
   at ProtoCore.DSASM.Heap.GCDisposeObject(StackValue svPtr, Executive exe)
   at ProtoCore.DSASM.Heap.Sweep()
   at ProtoCore.DSASM.Heap.SingleStep(Boolean forceGC)
   at ProtoCore.DSASM.Heap.FullGC(IEnumerable`1 gcroots, Executive exe)
   at ProtoScript.Runners.LiveRunner.ApplyUpdate()
   at ProtoScript.Runners.LiveRunner.CompileAndExecuteForDeltaExecution(List`1 astList)
   at ProtoScript.Runners.LiveRunner.SynchronizeInternal(GraphSyncData syncData)
   at ProtoScript.Runners.LiveRunner.UpdateGraph(GraphSyncData syncData)
   at Dynamo.Scheduler.UpdateGraphAsyncTask.HandleTaskExecutionCore()
   at Dynamo.Scheduler.AsyncTask.Execute()

OS: Microsoft Windows NT 10.0.19041.0 CLR: 4.0.30319.42000 Dynamo: `2.6.2.15 Set Category Visibility_2022-07-18_06-54-49

Set Category Visibility.dyn.txt 705`

github-actions[bot] commented 2 years ago

Hello rookiogmailcom, thank you for submitting this issue! We are super excited that you want to help us make Dynamo all that it can be. However, we need some more information in order for the Dynamo team to investigate any further.

Can you please fill in the following to the best of your ability:

Dynamo version
Operating system.

Additional information:

Filling in of the provided Template (What did you do, What did you expect to see, What did you see instead, What packages or external references (if any) were used)
Attaching the Stack Trace (Error message that shows up when Dynamo crashes - You can copy and paste this into the Github Issue)
Upload a .DYN file that showcases the issue in action and any additional needed files, such as Revit (Note: If you cannot share a project, you can recreate this in a quick mock-up file)
Upload a Screenshot of the error messages you see (Hover over the offending node and showcase said errors message in the screenshot)
Reproducible steps on how to create the error in question.

rookiogmailcom commented 2 years ago

I was getting the error every time I run the graph - by deleting the node view.setcategoryoverrides, I no longer get the crash. I'm now trying to find a way to achieve the result of amending view templates using different method

github-actions[bot] commented 2 years ago

Given that there has been no additional information added, this issue will be closed for now. Please reopen and provide additional information if you wish the Dynamo team to investigate further.

QilongTang commented 2 years ago

Moving this to DynamoRevit repo since the call stack is Revit related

DynamoDS / DynamoRevit