DynamoDS / DynamoRevit

Dynamo Libraries for Revit
https://dynamobim.org
334 stars 187 forks source link

Add support to UnwrapElement for marshaling CPython dictionary #2855

Closed aparajit-pratap closed 1 year ago

aparajit-pratap commented 2 years ago

Purpose

https://jira.autodesk.com/browse/DYN-5119 Add support to UnwrapElement for marshaling CPython dictionary

I basically tested the fix with the RC2.15_Revit2023.1 branch based on the Revit version I have installed, which is why I'm making this PR to that branch. I guess this will need to be cherry-picked into master as well.

I'm not sure where to add D4R tests. I remember writing tests for RTF but I don't have the setup anymore nor do I know if that's used anymore. Would need some help here.

Declarations

Check these if you believe they are true

Reviewers

@mjkkirschner

FYIs

@QilongTang @wangyangshi

wangyangshi commented 2 years ago

do you have any other changes, can I merge it now?

wangyangshi commented 2 years ago

add reviewer @ShengxiZhang

wangyangshi commented 1 year ago

have merged to master and RC2.16.1_Revit2023