Addition of new FamilyInstance.ByPointAndView node.

johnpierson commented 1 year ago

Purpose

This pull request adds a much-needed node to the mix for placing family instances in a given view at a given point. Typically, this is for Generic Annotations and Detail items (view specific components).

This node specifically will be very useful for a new example for the Dynamo player sample files for Revit. At this time I am using a python script, but an OOTB node would be great.

Revit_aKctRm5aZ7

(Let me know if I built this on the correct branch. At this time I am targeting 2023 because of ElementId.IntegerValue changing to ElementId.Value in the current master branch)

Declarations

Check these if you believe they are true

[x] The code base is in a better state after this PR
[x] Is documented according to the standards
[x] The level of testing this PR includes is appropriate
[x] User-facing strings, if any, are extracted into *.resx files
[x] Snapshot of UI changes, if any.

Reviewers

@ShengxiZhang

FYIs

@QilongTang @Amoursol @lillismith

mjkkirschner commented 1 year ago

hey @johnpierson it seems like something went wrong with this PR... it appears you have may have pushed directly to the RC2.13.1_2023.1 branch, and then sent a PR from that branch to master?

Unless I am missing something, can you please revert that and avoid pushing directly without making a PR first to the main branches? (ie non fork)

johnpierson commented 1 year ago

Ah, let me take a look. I do need to target 2023 though as I believe master is currently targeting a newer build.

mjkkirschner commented 1 year ago

ok, then you should make a PR from your fork (or a new branch in the repo) to 2023 - this PR is currently targeting master.

johnpierson commented 1 year ago

Ah heck. Okay let me figure out what I should do

johnpierson commented 1 year ago

Closed and reverted changes. Going to need a bit more guidance for targeting 2023 for these new nodes I want to add.

DynamoDS / DynamoRevit