Addition of new FamilyInstance.ByPointAndView node

johnpierson commented 2 years ago

Purpose

This pull request adds a much-needed node to the mix for placing family instances in a given view at a given point. Typically, this is for Generic Annotations and Detail items (view specific components).

This node specifically will be very useful for a new example for the Dynamo player sample files for Revit. At this time I am using a python script, but an OOTB node would be great.

Revit_aKctRm5aZ7

(Let me know if I built this on the correct branch. At this time I am targeting 2023 because of ElementId.IntegerValue changing to ElementId.Value in the current master branch)

Declarations

Check these if you believe they are true

[x] The code base is in a better state after this PR
[x] Is documented according to the standards
[x] The level of testing this PR includes is appropriate
[x] User-facing strings, if any, are extracted into *.resx files
[x] Snapshot of UI changes, if any.

Reviewers

@ShengxiZhang

FYIs

@mjkkirschner @QilongTang @Amoursol @lillismith

chuongmep commented 1 year ago

I don't understand why don't have any people work with this project, a pull request can't resolve in 1 month.

wangyangshi commented 1 year ago

Sorry we haven't noticed this, generally pull request should integrated to master first, then integrated to released branch. currently in Revit2023, its according branch should be RC2.16.1_Revit2023

johnpierson commented 1 year ago

I'll just close it and not bother then. Thanks.

FYI @Amoursol @mjkkirschner @saintentropy

DynamoDS / DynamoRevit