Display Splash Screen as part of Dynamo Revit

[QilongTang]

Please Note:

1. Before submitting the PR, please review How to Contribute to Dynamo
2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
3. PRs will be reviewed from oldest to newest
4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Display Splash Screen as part of Dynamo Revit. This PR depends on https://github.com/DynamoDS/Dynamo/pull/13492. Once the new nuget has been published, I will update the version again to make it review ready.

Declarations

Check these if you believe they are true

• [ ] The code base is in a better state after this PR
• [ ] Is documented according to the standards
• [ ] The level of testing this PR includes is appropriate
• [ ] User facing strings, if any, are extracted into *.resx files
• [ ] Snapshot of UI changes, if any.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

[QilongTang]

FYI: @wangyangshi I am going to test this locally and ping you for final review. Currently I am getting a build error locally which is confusing.. The nuget should exist at https://www.nuget.org/packages/DynamoVisualProgramming.ZeroTouchLibrary/2.17.0-beta3141

Unable to resolve 'DynamoVisualProgramming.ZeroTouchLibrary (>= 2.17.0-beta3141)' for '.NETFramework,Version=v4.8'

[wangyangshi]

FYI: @wangyangshi I am going to test this locally and ping you for final review. Currently I am getting a build error locally which is confusing.. The nuget should exist at https://www.nuget.org/packages/DynamoVisualProgramming.ZeroTouchLibrary/2.17.0-beta3141

Unable to resolve 'DynamoVisualProgramming.ZeroTouchLibrary (>= 2.17.0-beta3141)' for '.NETFramework,Version=v4.8'

OK let me pull this down and have a test too

[QilongTang]

FYI: @wangyangshi I am going to test this locally and ping you for final review. Currently I am getting a build error locally which is confusing.. The nuget should exist at https://www.nuget.org/packages/DynamoVisualProgramming.ZeroTouchLibrary/2.17.0-beta3141 Unable to resolve 'DynamoVisualProgramming.ZeroTouchLibrary (>= 2.17.0-beta3141)' for '.NETFramework,Version=v4.8'

OK let me pull this down and have a test too

Looks like it is a timing issue, now it builds fine for me. I will try to test it in Revit preview release to see if splash screen and login can function correctly

[wangyangshi]

@QilongTang Hi Aaron, Could you please add me to the repo https://github.com/DynamoDS/RevitTestFramework/, I am working on the rtf testing, need to do some changes, thank you

[QilongTang]

@QilongTang Hi Aaron, Could you please add me to the repo https://github.com/DynamoDS/RevitTestFramework/, I am working on the rtf testing, need to do some changes, thank you

Done. Added you as admin

[QilongTang]

@wangyangshi Can you point me to docs about these days how to test changes with DynamoRevit and DynamoCore together in Revit? I think my code changes should be good but getting some error launching DynamoRevit

[wangyangshi]

after building successfully, have you signed the d4r file? my experience is these files need to be signed, then revit can use them

[wangyangshi]

I think you can pull these scripts to your local machine, (https://git.autodesk.com/Dynamo/DynamoRevitUtils/tree/master) then use these scripts to build. 1 RevitAPInuGet.bat 2 BuildSolutions.bat 3 SignFile.bat

[QilongTang]

I think you can pull these scripts to your local machine, (https://git.autodesk.com/Dynamo/DynamoRevitUtils/tree/master) then use these scripts to build. 1 RevitAPInuGet.bat 2 BuildSolutions.bat 3 SignFile.bat

I may try later, currently what I did:

1. Build DynamoRevit solution correctly (this branch)
2. Copy DynamoRevitDS.dll over to the Revit folder to replace the existing one
3. Build Dynamo solution correctly (master branch)
4. Copy the built content under bin folder over to the AddIns\DynamoForRevit folder under Revit
5. Launch Revit and Launch D4R
6. I got an error which.. I think should not exist

[wangyangshi]

could you please have a try like below? 1 remove the folder DynamoForRevit in Addins 2 add a file Dynamo.addin in C:\ProgramData\Autodesk\Revit\Addins\2024

like its content is like

that will point revit to use the d4r you build.

[wangyangshi]

https://wiki.autodesk.com/display/aeceng/How+to+Get+DynamoCoreRuntime+Package+in+DynamoRevit+Development

[wangyangshi]

@QilongTang Hi Aaron, do we need to merge this PR before I integrate DC2.17? is the version 2.17.0-beta3141?

[QilongTang]

hi @wangyangshi It would be good that you review this PR and if there is anything unclear, our team should be able to help your team by adding more comments or cleaning up the code more. 2.17.0-beta3141 is simply the API stable nuget, when the release is out, we will publish the final one. There is another alternative that you update to 2.17.0-beta3141 without merging this PR, but that would mean Splash Screen would not show up in DynamoRevit.

[wangyangshi]

OK, so currently the finial release version hasn't released, do you think should we wait for the final release or integrate the beta first? which beta version is recommended?

[QilongTang]

OK, so currently the finial release version hasn't released, do you think should we wait for the final release or integrate the beta first? which beta version is recommended?

I would recommend integrate beta version first, the version I recommend is currently building by CI. Should be ready in 1 hour.

[wangyangshi]

@QilongTang Hi Aaron, if the final beta version is ready and released, please let me know, as time is limit I will integrate it at first time, thank you

[QilongTang]

@QilongTang Hi Aaron, if the final beta version is ready and released, please let me know, as time is limit I will integrate it at first time, thank you

Please check deer server and artifactory, the beta release build should be there (please use latest from today).

[wangyangshi]

I userd DynamoCoreRuntime 2.17.0.3260, tested locally there are some 11 failures in 381 system test, and the splash window cannot be closed I am investigating the failures reason

[mjkkirschner]

@wangyangshi please share a list of failures here or on slack.

[wangyangshi]

// List of Failures for job: // 1123_225436_Wangyang_Shi_dynamo2.17 AddIns\Dynamo\SteelConnections\BasePlate\BasePlate.txt AddIns\Dynamo\SteelConnections\ConnectionByType\ConnectionByType.txt AddIns\Dynamo\SteelConnections\FilterByMemberEndForces\FilterByMemberEndForces.txt AddIns\Dynamo\SteelConnections\IBracingSplice\IBracingSplice.txt AddIns\Dynamo\SteelConnections\KneeOfFrame\KneeOfFrame.txt AddIns\Dynamo\SteelConnections\LoadFromFile\LoadFromFile.txt AddIns\Dynamo\SteelConnections\MatchTypeByRanges\MatchTypeByRanges.txt AddIns\Dynamo\SystemTests\Document\DisableRunWhenOpenADocInPersView.txt AddIns\Dynamo\SystemTests\Document\InitialUIDocIsNotNull.txt AddIns\Dynamo\SystemTests\Document\OpeningNewDocNoSwitchUIDoc.txt AddIns\Dynamo\SystemTests\Workflow\Test_PerforationsByImage.txt

[wangyangshi]

I will merge this pull request to Revit first for other guys to test the new features. other issues we can fix them later.