Fix issue with localization for SelectByCategory Nodes

saintentropy commented 1 year ago

Purpose

The purpose of this PR is to address an issue observer when switching between Revit localizations with a the SelectByCategory node. The node does not deserialize to the correct selected filter categroy if when opened in a different localization from where it was saved.

Declarations

Check these if you believe they are true

[ ] The code base is in a better state after this PR
[ ] Is documented according to the standards
[ ] The level of testing this PR includes is appropriate
[ ] User facing strings, if any, are extracted into *.resx files
[ ] Snapshot of UI changes, if any.

Reviewers

@BogdanZavu @twastvedt

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

saintentropy commented 1 year ago

@wangyangshi are there any tests that currently test a localization issue like this one?

saintentropy commented 1 year ago

@wangyangshi can you confirm that the new and modified tests are running correctly?

wangyangshi commented 1 year ago

Yes, the system/unit test can be searched in the project, test calls the node function

wangyangshi commented 1 year ago

Yes, let me run the test today, once I get the results I will update it here.

jnealb commented 1 year ago

Just an fyi: the Jira ticket for this is https://jira.autodesk.com/browse/AGD-2087

DynamoDS / DynamoRevit